Remove downlevel runtimes from global.json #40393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
1 task
dougbu
approved these changes
Feb 24, 2022
dougbu
reviewed
Mar 2, 2022
global.json
Outdated
| @@ -6,14 +6,10 @@ | |||
| "dotnet": "7.0.100-preview.2.22114.1", | |||
| "runtimes": { | |||
| "dotnet": [ | |||
| "2.1.30", | |||
| "$(MicrosoftNETCoreBrowserDebugHostTransportVersion)" | |||
| ], | |||
| "dotnet/x86": [ | |||
There was a problem hiding this comment.
@wtgodbe may want to move this section above "dotnet" so eng/scripts/prepare-sourcebuild-globaljson.sh works as expected.
@MichaelSimons the alternative would be to stop using eng/scripts/prepare-sourcebuild-globaljson.sh. Will that work correctly now❔
There was a problem hiding this comment.
It looks to me like we will still need eng/scripts/prepare-sourcebuild-globaljson.sh because of the dotnet/x86 entry.
wtgodbe
added a commit
that referenced
this pull request
Mar 14, 2022
wtgodbe
added a commit
that referenced
this pull request
Mar 14, 2022
wtgodbe
added a commit
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead rely on the implicit versions in the SDK, which stay up-to-date anyways (see https://github.com/dotnet/installer/blob/b6c29ddce6f3d0472e3449bb65fef6c08b9bd644/src/redist/targets/GenerateBundledVersions.targets#L27-L32). Allows for building on platforms that weren't supported on older runtimes, like Apple M1 Silicon (see #40109)