Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update post-build.yml to pass path to SignCheckExclusionsFile #3572

Merged
merged 2 commits into from
Aug 6, 2019

Conversation

JohnTortugo
Copy link
Contributor

@JohnTortugo JohnTortugo commented Aug 5, 2019

Need to add this to pass the parameter to the signing validation step so that users can inform files that should be excluded from signing validation.

Test build is running here: https://dnceng.visualstudio.com/internal/_build/results?buildId=295740&view=results

@JohnTortugo JohnTortugo self-assigned this Aug 5, 2019
@AaronRobinsonMSFT
Copy link
Member

@JohnTortugo I am actually changing my mind here. Why is the extension here .props? The SignCheck tool's exclusion list seems to be a flat text file rather than an MSBuild file.

public Exclusions(string path)
{
if (File.Exists(path))
{
using (StreamReader fileReader = File.OpenText(path))
{
string line = fileReader.ReadLine();
while (line != null)
{
if (!String.IsNullOrEmpty(line))
{
Add(new Exclusion(line));
}
line = fileReader.ReadLine();
}
}
}
}

@AaronRobinsonMSFT AaronRobinsonMSFT self-requested a review August 5, 2019 23:39
@JohnTortugo JohnTortugo merged commit ee99861 into master Aug 6, 2019
@JohnTortugo JohnTortugo deleted the JohnTortugo-patch-1 branch August 6, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants