-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add support for servicing (post-build.yml) #26020
Add support for servicing (post-build.yml) #26020
Conversation
we're trying to use a single area label or the labeler bot will get confused |
151e922
to
ae56056
Compare
@AaronRobinsonMSFT will this also fix the publish to BAR failures in official builds? https://dnceng.visualstudio.com/internal/_build/results?buildId=300175 |
@ViktorHofer I don't really know the answer to that. If I had to guess, I would say 'yes' because this is the official Arcade approach. Perhaps @elinor-fung or @mmitche could speak to that problem and how it relates to this work. |
…nupkgs are signed)
This reverts commit a52ef187e94578274cc86e61abfecd209309e4bb.
ae56056
to
e04043a
Compare
This reverts commit 3269a8d.
@ViktorHofer I don't know what that exact failure is, but it's quite possible this could get rid of it (by working around it entirely) |
@AaronRobinsonMSFT any idea what's causing some legs (ie PublishAssets in .NET Tools - Master) to have an "abandoned" state? Unfortunately we still don't see a new coreclr build in corefx. cc @stephentoub |
@ViktorHofer Can you point me to the failing issue? Is this in corefx or coreclr. Note that CoreCLR hasn't been succeeding in quite some time and the current official build issues in CoreCLR seem to be related to missing NuGet feeds so like my comment in the referenced issue, I don't see how the connection is being made to this work. |
https://dnceng.visualstudio.com/internal/_build/results?buildId=305428
I did not intend to criticize your work here at all. I just thought as you introduced the new templates you might have context on the "abandoned" states. |
Ah, I see the connection now. Those steps are defined by Arcade and execute when the build succeeds - at least I think that is the trigger. In this case tests are failing for the above mentioned issue with NuGet so I don't know if they are expected to run. Note that any stages/jobs outside of the "Build" stage are defined by Arcade and I would expect any repo consuming them to hit similar issues. Do you know if CoreFX has moved over to Arcade publishing? @JohnTortugo @mmitche Can either of you comment on why the publishing steps in the reference build would be marked "abandoned"? Is this related to the failing tests in that leg? I would have instead expected them to be marked as "skipped" |
Yes we have. This is one of our builds where the legs ran successfully: https://dnceng.visualstudio.com/internal/_build/results?buildId=305712. |
Thanks for the link. This is how it was running for me during testing when no tests were running. This means we need to verify that tests don't cause subsequent jobs to get abandoned. I will start a thread offline and include you so we can get to the bottom of the issue. |
* Use stages for internal build * Remove publishwitharcade project
* Use stages for internal build * Remove publishwitharcade project
* Use stages for internal build * Remove publishwitharcade project Commit migrated from dotnet/coreclr@ecca02d
Blocked by dotnet/arcade#3572cc @JohnTortugo @mmitche
@dotnet/coreclr-infra