Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add support for servicing (post-build.yml) #26020

Merged
merged 9 commits into from
Aug 10, 2019

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Aug 5, 2019

Blocked by dotnet/arcade#3572

cc @JohnTortugo @mmitche

@dotnet/coreclr-infra

@danmoseley
Copy link
Member

we're trying to use a single area label or the labeler bot will get confused

@AaronRobinsonMSFT AaronRobinsonMSFT force-pushed the update_to_stages branch 2 times, most recently from 151e922 to ae56056 Compare August 7, 2019 21:51
@ViktorHofer
Copy link
Member

@AaronRobinsonMSFT will this also fix the publish to BAR failures in official builds? https://dnceng.visualstudio.com/internal/_build/results?buildId=300175

@AaronRobinsonMSFT
Copy link
Member Author

@ViktorHofer I don't really know the answer to that. If I had to guess, I would say 'yes' because this is the official Arcade approach. Perhaps @elinor-fung or @mmitche could speak to that problem and how it relates to this work.

@mmitche
Copy link
Member

mmitche commented Aug 9, 2019

@ViktorHofer I don't know what that exact failure is, but it's quite possible this could get rid of it (by working around it entirely)

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit ecca02d into dotnet:master Aug 10, 2019
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the update_to_stages branch August 10, 2019 00:51
@ViktorHofer
Copy link
Member

@AaronRobinsonMSFT any idea what's causing some legs (ie PublishAssets in .NET Tools - Master) to have an "abandoned" state? Unfortunately we still don't see a new coreclr build in corefx.

cc @stephentoub

@AaronRobinsonMSFT
Copy link
Member Author

@ViktorHofer Can you point me to the failing issue? Is this in corefx or coreclr. Note that CoreCLR hasn't been succeeding in quite some time and the current official build issues in CoreCLR seem to be related to missing NuGet feeds so like my comment in the referenced issue, I don't see how the connection is being made to this work.

@ViktorHofer
Copy link
Member

Can you point me to the failing issue?

https://dnceng.visualstudio.com/internal/_build/results?buildId=305428

I don't see how the connection is being made to this work.

I did not intend to criticize your work here at all. I just thought as you introduced the new templates you might have context on the "abandoned" states.

@AaronRobinsonMSFT
Copy link
Member Author

Ah, I see the connection now. Those steps are defined by Arcade and execute when the build succeeds - at least I think that is the trigger. In this case tests are failing for the above mentioned issue with NuGet so I don't know if they are expected to run.

Note that any stages/jobs outside of the "Build" stage are defined by Arcade and I would expect any repo consuming them to hit similar issues. Do you know if CoreFX has moved over to Arcade publishing?

@JohnTortugo @mmitche Can either of you comment on why the publishing steps in the reference build would be marked "abandoned"? Is this related to the failing tests in that leg? I would have instead expected them to be marked as "skipped"

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 12, 2019

Do you know if CoreFX has moved over to Arcade publishing?

Yes we have. This is one of our builds where the legs ran successfully: https://dnceng.visualstudio.com/internal/_build/results?buildId=305712.

@AaronRobinsonMSFT
Copy link
Member Author

Thanks for the link. This is how it was running for me during testing when no tests were running. This means we need to verify that tests don't cause subsequent jobs to get abandoned. I will start a thread offline and include you so we can get to the bottom of the issue.

AaronRobinsonMSFT added a commit to AaronRobinsonMSFT/coreclr that referenced this pull request Aug 12, 2019
* Use stages for internal build

* Remove publishwitharcade project
AaronRobinsonMSFT added a commit to AaronRobinsonMSFT/coreclr that referenced this pull request Aug 19, 2019
* Use stages for internal build

* Remove publishwitharcade project
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Use stages for internal build

* Remove publishwitharcade project


Commit migrated from dotnet/coreclr@ecca02d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants