Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Tell Arcade to continue on error for test runs. #26134

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Tell Arcade to continue on error for test runs. #26134

merged 1 commit into from
Aug 12, 2019

Conversation

AaronRobinsonMSFT
Copy link
Member

See #26020 (comment)

/cc @dotnet/coreclr-infra

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 5.0 milestone Aug 12, 2019
hoyosjs
hoyosjs approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we (used to) flow assets regardless of test results, this is just to make assets not to be stale, right? Basically, there's no observable difference other than in dependency flow.

@AaronRobinsonMSFT
Copy link
Member Author

Basically, there's no observable difference other than in dependency flow.

@hoyosjs I believe that is true.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 566fa8b into dotnet:master Aug 12, 2019
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the tests_continueOnError branch August 12, 2019 19:36
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@AaronRobinsonMSFT
Tell Arcade to continue on error for test runs. (dotnet/coreclr#26134)
5c0459c 
Commit migrated from dotnet/coreclr@566fa8b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@jashook jashook jashook approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

@elinor-fung elinor-fung elinor-fung approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AaronRobinsonMSFT @jkoritzinsky @jashook @hoyosjs @elinor-fung