Set more variables in the DOTNET_CLI path #5284
Conversation
- Set DOTNET_ROOT to the dotnet path - Set DOTNET_CLI_TELEMETRY_OPTOUT=1 - Set DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
| <HelixPreCommands Condition="$(IsPosixShell)">$(HelixPreCommands);export DOTNET_CLI_TELEMETRY_OPTOUT=1</HelixPreCommands> | ||
| <HelixPreCommands Condition="!$(IsPosixShell)">$(HelixPreCommands);set DOTNET_CLI_TELEMETRY_OPTOUT=1</HelixPreCommands> | ||
| <HelixPreCommands Condition="$(IsPosixShell)">$(HelixPreCommands);export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1</HelixPreCommands> | ||
| <HelixPreCommands Condition="!$(IsPosixShell)">$(HelixPreCommands);set DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1</HelixPreCommands> |
There was a problem hiding this comment.
DOTNET_SKIP_FIRST_TIME_EXPERIENCE does nothing nowadays so this can be removed.
There was a problem hiding this comment.
It was removed for some reason in dotnet/cli@7efbf47, then reintroduced with a different name in dotnet/sdk@9c7f651. Nowadays, it goes by DOTNET_NOLOGO=1. 🤣
|
Any chance of getting this in? AspNetCore would be able to switch to using the built in cli support in helix with these tweaks, followup PR we'd do is here dotnet/aspnetcore#20876 |
|
Hello @pranavkm! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
| <PropertyGroup> | ||
| <HelixPreCommands Condition="$(IsPosixShell)">$(HelixPreCommands);export PATH=$HELIX_CORRELATION_PAYLOAD/dotnet:$PATH</HelixPreCommands> | ||
| <HelixPreCommands Condition="!$(IsPosixShell)">$(HelixPreCommands);set PATH=%HELIX_CORRELATION_PAYLOAD%\dotnet%3B%PATH%</HelixPreCommands> <!-- %3B is an escaped ; --> | ||
| <HelixPreCommands Condition="$(IsPosixShell)">$(HelixPreCommands);export DOTNET_ROOT=$HELIX_CORRELATION_PAYLOAD/dotnet;export DOTNET_CLI_TELEMETRY_OPTOUT=1</HelixPreCommands> |
There was a problem hiding this comment.
These commands will not work as they are. If you look above, to have a literal semicolon in the commands it needs to be escaped with %3B otherwise it is treated as a command separator.
There was a problem hiding this comment.
Actually no, this is fine. These are intentionally separate commands. It looked weird having 2 commands in the same line.
|
@alexperovich the real question is if this merged on 7/1 why are we both getting alerts for it today :) |
|
wow, thats true. lol |
I don't know if this is too aggressive. Let me know.
cc @HaoK