Skip to content

Set more variables in the DOTNET_CLI path #5284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pranavkm merged 2 commits into from
Jul 1, 2020
Merged

Set more variables in the DOTNET_CLI path #5284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49342b0
Set more variables in the DOTNET_CLI path
davidfowl Apr 16, 2020
3e4a43d
Update DotNetCli.targets
pranavkm Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Microsoft.DotNet.Helix/Sdk/tools/dotnet-cli/DotNetCli.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
<PropertyGroup>
<HelixPreCommands Condition="$(IsPosixShell)">$(HelixPreCommands);export PATH=$HELIX_CORRELATION_PAYLOAD/dotnet:$PATH</HelixPreCommands>
<HelixPreCommands Condition="!$(IsPosixShell)">$(HelixPreCommands);set PATH=%HELIX_CORRELATION_PAYLOAD%\dotnet%3B%PATH%</HelixPreCommands> <!-- %3B is an escaped ; -->
<HelixPreCommands Condition="$(IsPosixShell)">$(HelixPreCommands);export DOTNET_ROOT=$HELIX_CORRELATION_PAYLOAD/dotnet;export DOTNET_CLI_TELEMETRY_OPTOUT=1</HelixPreCommands>
Copy link
Member

@alexperovich alexperovich Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commands will not work as they are. If you look above, to have a literal semicolon in the commands it needs to be escaped with %3B otherwise it is treated as a command separator.

Copy link
Member

@alexperovich alexperovich Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no, this is fine. These are intentionally separate commands. It looked weird having 2 commands in the same line.

<HelixPreCommands Condition="!$(IsPosixShell)">$(HelixPreCommands);set DOTNET_ROOT=%HELIX_CORRELATION_PAYLOAD%\dotnet;set DOTNET_CLI_TELEMETRY_OPTOUT=1</HelixPreCommands>
</PropertyGroup>
</Target>
</Project>