Add inferred runtime identifiers #7141
Conversation
During source build it's desirable to add RIDs to the runtime graph without actually. Making a change to sources. For example: the tar-ball is produced and then built on some new distro. The added RID should follow the compatibility rules for existing RIDs so we parse it and try to find the most appropriate RuntimeGroup to add it to.
| char current = runtimeIdentifier[i]; | ||
| partLength = i - partStart; | ||
|
|
||
| switch (parseState) |
There was a problem hiding this comment.
Did you consider using a regular expression for parsing instead?
There was a problem hiding this comment.
Yeah I had a regex and it was much more difficult to read once it was complicated enough to handle all cases and capture all fields that we needed. This simple state machine is easier to read and debug (and happens to be more efficient though that's not a real concern for this one shot task).
|
Does anyone except dotnet/runtime mutate the runtime graph? Would dotnet/runtime be a better place for the runtime graph code to live? |
This has a single consumer in dotnet\runtime: The platforms package. If there was a good place in dotnet/runtime to both build and test tasks we could move it, though I'm not seeing a ton of value in doing so.. At the time this was written that wasn't the case. I don't think we should block the addition of this feature on moving this out of arcade. Perhaps when we want to remove the pkgproj stuff we can move this to dotnet/runtime. |
Versions may contain insignificant whitespace which must be preserved.
ericstj
force-pushed
the
AddInferredRuntimeIdentifiers
branch
from
1381776 to
c537d55
Compare
|
Note to reviewers: best to review all changes after first refactoring commit (checkout GitHub's shift-click feature to reduce the commit range). |
Unrelated to this PR but let me respond. If there's only a single consumer then the code shouldn't live in Arcade. There is infrastructure in dotnet/runtime that allows to build tasks, test and consume them.
Neither do I. It was a side comment unrelated to this PR as I wasn't aware that this code exists in the packaging code. |
|
Marking no-merge as I plan to move this to dotnet/runtime |
|
We're moving this code to dotnet/runtime |
During source build it's desirable to add RIDs to the runtime graph
without actually. Making a change to sources.
For example: the tar-ball is produced and then built on some new distro.
The added RID should follow the compatibility rules for existing RIDs
so we parse it and try to find the most appropriate RuntimeGroup to add
it to.
cc @tmds @omajid