Add OutputRID to RID graph during source build #50157
Conversation
Also support the addition of RIDs through InferRuntimeIdentifiers.
ericstj
added
the
NO-MERGE
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| @@ -5,14 +5,25 @@ | |||
| <!-- We don't need to harvest the stable packages to build this --> | |||
| <HarvestStablePackage>false</HarvestStablePackage> | |||
| <PackageDescription>Provides runtime information required to resolve target framework, platform, and runtime specific implementations of .NETCore packages.</PackageDescription> | |||
| <InferRuntimeIdentifiers Condition="'$(DotNetBuildFromSource)' == 'true'">$(InferRuntimeIdentifiers);$(OutputRID)</InferRuntimeIdentifiers> | |||
There was a problem hiding this comment.
It looks like we have both PackageRID and OutputRID since the runtime consolidation. I'm not sure why we have two: they both seem to try to be accomplishing the same thing. I use OutputRID here since that's what installer appears to use.
There was a problem hiding this comment.
I believe @jkoritzinsky is who has more context about OutputRID vs PackageRID but it seems like installer uses PackageRID to restore tooling and stuff and OutputRID is the rid to produce the package for.
There was a problem hiding this comment.
installer uses PackageRID to restore tooling and stuff
I don't think its tooling. I think installer uses this to for selecting packages from CoreCLR / Libraries (was more relevant when those were separate repos). I'm 90% sure that its wrong to have two different properties here.
There was a problem hiding this comment.
Yep something like that was I couldn't remember exactly. I think we should just use PackageRID and remove OutputRID
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsAlso support the addition of RIDs through InferRuntimeIdentifiers. Needs dotnet/arcade#7141 (current staged in side-channel feed)
|
|
Would it make any sense to add (reuse?) a CI leg that sets up an environment with an unknown/fake RID and verify that the RID is present in the generated RID graph? |
I cover the RID graph addition testing to produce the right runtime.json in the arcade side of this. https://github.com/dotnet/arcade/pull/7141/files#diff-dfd25c6d9740edaacaab6c8000e0bbc3d164ac6bc024c1d850c6e4d48509e583R44 We do have a source-build leg already. Perhaps we could add usage of |
ghost
closed this
|
Draft Pull Request was automatically closed for inactivity. It can be manually reopened in the next 30 days if the work resumes. |
ghost
locked as resolved and limited conversation to collaborators
Also support the addition of RIDs through InferRuntimeIdentifiers.
Fixes #48507
cc @omajid
Needs dotnet/arcade#7141 (current staged in side-channel feed)