Make sbom generation optional in repos that insert to VS (PR builds) #9337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGal
reviewed
May 11, 2022
| <GenerateSbom Condition="'$(GenerateSbom)' == ''">false</GenerateSbom> | ||
| </PropertyGroup> | ||
|
|
||
| <Target Name ="GenerateSbomForVSInsertion" |
There was a problem hiding this comment.
I personally prefer == 'true' for this sort of clause.
There was a problem hiding this comment.
Yep, a double negative makes it harder to process mentally
MattGal
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check:
Test build -> https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6140675&view=logs&j=4032467e-dc57-5727-0bde-0b3f32a19231&t=d467e7d5-e028-5fd4-b25f-2746de72cefc
(Here Build passed and created VS manifest and did not create SBOM)