Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sbom generation optional in repos that insert to VS (PR builds) #9337

Merged
merged 1 commit into from
May 11, 2022
Merged

Make sbom generation optional in repos that insert to VS (PR builds) #9337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Microsoft.DotNet.Arcade.Sdk/tools/VisualStudio.InsertionManifests.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@
<!--
Before pack create the SBOM here
-->
<Target Name ="GenerateSbomForVSInsertion">
<PropertyGroup>
<GenerateSbom Condition="'$(GenerateSbom)' == ''">false</GenerateSbom>
</PropertyGroup>

<Target Name ="GenerateSbomForVSInsertion"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer == 'true' for this sort of clause.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, a double negative makes it harder to process mentally

Condition="'$(GenerateSbom)' != 'false'">
<Message Text="Generating SBOM manifest" Importance="high"/>
<ItemGroup>
<VsixFile Include="$(ArtifactsDir)VSSetup\$(Configuration)\Insertion\*.vsix"></VsixFile>
Expand Down