-
Notifications
You must be signed in to change notification settings - Fork 770
Add test coverage for --aspire-version template option #9433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: danmoseley <6385855+danmoseley@users.noreply.github.com>
--aspire-version template option
radical
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds automated tests to verify the newly supported --aspire-version template option works correctly for versions 9.2 and 9.3 across all SDK and TFM combinations.
- Introduces two new
MemberDataentries to cover--aspire-version 9.2and--aspire-version 9.3. - Ensures the existing test infrastructure runs these cases alongside other template tests.
Comments suppressed due to low confidence (1)
tests/Aspire.Templates.Tests/NewUpAndBuildSupportProjectTemplatesTests.cs:19
- Consider adding negative or unsupported version tests (e.g.,
--aspire-version 10.0or invalid strings) to validate proper error handling, and expand coverage to other templates (likeaspire-starteroraspire-webapi) that also accept the--aspire-versionoption.
[MemberData(nameof(TestDataForNewAndBuildTemplateTests), arguments: ["aspire-xunit", "--aspire-version 9.2"])]
tests/Aspire.Templates.Tests/NewUpAndBuildSupportProjectTemplatesTests.cs
Show resolved
Hide resolved
|
@danmoseley this looks ready. Do we want to make any other changes here before merging? |
|
incidentally @radical it does seem to be mostly building OK now but not able to run the template tests specifically due to firewall. hopefully it's only those that need network access |
|
Just curious, this PR only has a small change that only seems to test the |
|
Indeed. @radical what is the state of our template coverage overall nowadays? I see this commented |
This PR adds test coverage for the
--aspire-versiontemplate option to ensure it works correctly across different framework targets.Changes
Added tests in
NewUpAndBuildSupportProjectTemplatesTests.csfor:--aspire-version 9.2--aspire-version 9.3These test cases will run across all SDK and target framework combinations through the existing test infrastructure, ensuring comprehensive coverage of this option.
Motivation
With .NET 9.1 adding support for selecting between versions 8.2, 9.0, and 9.1 (depending on the target framework), we needed test coverage for this potentially fragile area of the codebase.
The added test cases validate that the template parameter works correctly in all supported environments.
Fixes #7279.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
azuresearch-usnc.nuget.org/home/REDACTED/work/aspire/aspire/artifacts/bin/dotnet-tests/dotnet new aspire-starter -o aspire-starter_net9.0_h5q3ofcj_n3q -f net9.0 --debug:custom-hive /tmp/templates-$6d9d664d/templates(dns block)/home/REDACTED/work/aspire/aspire/artifacts/bin/dotnet-tests/dotnet new aspire-starter --use-redis-cache -o aspire-starter_net8.0_m0lf40se_wsj -f net8.0 --debug:custom-hive /tmp/templates-$6d9d664d/templates(dns block)azuresearch-ussc.nuget.org/home/REDACTED/work/aspire/aspire/artifacts/bin/dotnet-tests/dotnet new aspire-starter -o aspire-starter_net9.0_h5q3ofcj_n3q -f net9.0 --debug:custom-hive /tmp/templates-$6d9d664d/templates(dns block)dnceng.pkgs.visualstudio.com/home/REDACTED/work/aspire/aspire/.dotnet/dotnet build tests/Aspire.Templates.Tests/Aspire.Templates.Tests.csproj(dns block)/home/REDACTED/work/aspire/aspire/.dotnet/dotnet test tests/Aspire.Templates.Tests/Aspire.Templates.Tests.csproj --filter FullyQualifiedName~NewUpAndBuildSupportProjectTemplates.CanNewAndBuild --logger console;verbosity=detailed(dns block)/home/REDACTED/work/aspire/aspire/.dotnet/dotnet build tests/workloads.proj(dns block)pkgs.dev.azure.com/home/REDACTED/work/aspire/aspire/.dotnet/dotnet build tests/Aspire.Templates.Tests/Aspire.Templates.Tests.csproj(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)/home/REDACTED/work/aspire/aspire/.dotnet/dotnet test tests/Aspire.Templates.Tests/Aspire.Templates.Tests.csproj --filter FullyQualifiedName~NewUpAndBuildSupportProjectTemplates.CanNewAndBuild --logger console;verbosity=detailed(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.