Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Identity queries once EF issue is fixed #10668

Closed
ajcvickers opened this issue May 30, 2019 · 1 comment · Fixed by #11336
Closed

Revert Identity queries once EF issue is fixed #10668

ajcvickers opened this issue May 30, 2019 · 1 comment · Fixed by #11336
Assignees
@ajcvickers
Labels
area-identity Includes: Identity and providers Done This issue has been fixed
Milestone
3.0.0-preview7

Comments

@ajcvickers
Copy link
Member

See EF issue: dotnet/efcore#15866

Impacted files: UserStore.cs, UserOnlyStore.cs
@ajcvickers ajcvickers added the area-identity Includes: Identity and providers label May 30, 2019
@ajcvickers ajcvickers self-assigned this May 30, 2019
@ajcvickers ajcvickers added this to the 3.0.0-preview7 milestone May 30, 2019
@smitpatel
Copy link
Contributor

Underlying EF Core issues are fixed.

ajcvickers added a commit that referenced this issue Jun 5, 2019
@ajcvickers
Cleanup in Identity tests
dccb66a 
Fixes #10671 by using updated EF API
Fixes #5812 so tests are re-enabled for PRs
Also part of #10668 since one of the changed EF queries is now working

Finally, I removed all remaining platform skips since with SQLite these tests should now run anywhere.
@ajcvickers ajcvickers mentioned this issue Jun 5, 2019
Merged
ajcvickers added a commit that referenced this issue Jun 5, 2019
@ajcvickers
Cleanup in Identity tests
a86a811 
Fixes #10671 by using updated EF API
Fixes #5812 so tests are re-enabled for PRs
Also part of #10668 since one of the changed EF queries is now working

Finally, I removed all remaining platform skips since with SQLite these tests should now run anywhere.
ajcvickers added a commit that referenced this issue Jun 18, 2019
@ajcvickers
Update MusicStore and Identity to remove workarounds
eb4b8c3 
Fixes #10714
Fixes #10668
@ajcvickers ajcvickers mentioned this issue Jun 18, 2019
Merged
ajcvickers added a commit that referenced this issue Jun 18, 2019
@ajcvickers
Update MusicStore and Identity to remove workarounds
839cf89 
Fixes #10714
Fixes #10668
@ajcvickers ajcvickers added the Done This issue has been fixed label Jun 18, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajcvickers ajcvickers

Labels
area-identity Includes: Identity and providers Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview7
Development

Successfully merging a pull request may close this issue.

Update MusicStore and Identity to remove workarounds dotnet/aspnetcore
2 participants
@ajcvickers @smitpatel