Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Identity query failures #15866

Closed
ajcvickers opened this issue May 30, 2019 · 1 comment · Fixed by #15930
Closed

Query: Identity query failures #15866

ajcvickers opened this issue May 30, 2019 · 1 comment · Fixed by #15930
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

With the new pipeline, queries of the following form are failing:

await UserClaims.Where(uc => uc.UserId.Equals(user.Id)).Select(c => c.ToClaim()).ToListAsync(cancellationToken);

Issues of the following form may also be failing, but this may be a red herring:

Users.SingleOrDefaultAsync(u => u.NormalizedEmail == normalizedEmail, cancellationToken);
@ajcvickers ajcvickers mentioned this issue May 30, 2019
Closed
@ajcvickers ajcvickers added this to the 3.0.0 milestone May 31, 2019
smitpatel added a commit that referenced this issue Jun 4, 2019
@smitpatel
Query: Allow client projection to cause materialization
ab96491 
This changes SqlTranslatingExpressionVisitor to return null rather than throwing InvalidCastExpression when something failed to translate to Sql

Part of #15866
@smitpatel smitpatel mentioned this issue Jun 4, 2019
Merged
@smitpatel
Copy link
Contributor

#15927 fixes first failure.
Second failure is duplicate of #15559 which does not throw at present.

smitpatel added a commit that referenced this issue Jun 4, 2019
@smitpatel
Query: Enable throwing behavior for Single/SingleOrDefault on top level
d128a18 
In future we need to detect cases when it is used inside subquery to not throw but currently all such tests are disabled because it was doing client eval in previous pipeline

Part of #15559
Resolves #15866
@smitpatel smitpatel mentioned this issue Jun 4, 2019
Merged
smitpatel added a commit that referenced this issue Jun 4, 2019
@smitpatel
Query: Allow client projection to cause materialization
f9e8c4a 
This changes SqlTranslatingExpressionVisitor to return null rather than throwing InvalidCastExpression when something failed to translate to Sql

Part of #15866
smitpatel added a commit that referenced this issue Jun 4, 2019
@smitpatel
Query: Enable throwing behavior for Single/SingleOrDefault on top level
7081516 
In future we need to detect cases when it is used inside subquery to not throw but currently all such tests are disabled because it was doing client eval in previous pipeline

Part of #15559
Resolves #15866
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 4, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview7, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Query: Enable throwing behavior for Single/SingleOrDefault on top level dotnet/efcore
2 participants
@ajcvickers @smitpatel