Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to arcade YAML templates #11924

Closed
JunTaoLuo opened this issue Jul 5, 2019 · 5 comments · Fixed by dotnet/ef6#1129 or dotnet/efcore#17040
Closed

Convert to arcade YAML templates #11924

JunTaoLuo opened this issue Jul 5, 2019 · 5 comments · Fixed by dotnet/ef6#1129 or dotnet/efcore#17040
Assignees
@dougbu
Labels
Done This issue has been fixed

Comments

@JunTaoLuo
Copy link
Contributor

Follow up to #11122 for the work item to use the Arcade YAML templates for CI definition.

Converting to the stages templates should also help with maestro publishing.
@JunTaoLuo JunTaoLuo added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 5, 2019
@dougbu dougbu added the blocked The work on this issue is blocked due to some dependency label Jul 5, 2019
@dougbu dougbu self-assigned this Jul 9, 2019
@dougbu dougbu removed the blocked The work on this issue is blocked due to some dependency label Jul 15, 2019
@dougbu
Copy link
Member

dougbu commented Jul 20, 2019 •
edited
Loading

dougbu added a commit to dotnet/razor that referenced this issue Jul 22, 2019
@dougbu
Use Arcade post-build stage template
a036f1f 
- dotnet/aspnetcore#11924
@dougbu dougbu mentioned this issue Jul 22, 2019
Merged
dougbu added a commit to dotnet/razor that referenced this issue Jul 23, 2019
@dougbu
Use Arcade post-build stage template
edbcd60 
- dotnet/aspnetcore#11924
@dougbu dougbu mentioned this issue Jul 23, 2019
Merged
dougbu added a commit to dotnet/razor that referenced this issue Jul 24, 2019
@dougbu
Use Arcade post-build stage template
baffa5b 
- dotnet/aspnetcore#11924
@dougbu dougbu mentioned this issue Jul 26, 2019
Merged
dougbu added a commit to dotnet/blazor that referenced this issue Aug 7, 2019
@dougbu
Use Arcade post-build stage template
6cdcf0c 
- dotnet/aspnetcore#11924
@dougbu dougbu mentioned this issue Aug 7, 2019
Merged
@dougbu
Copy link
Member

dougbu commented Aug 7, 2019

@wtgodbe I think I've got Blazor working now. Why don't you have a look at the EF repos?

I'll jump to AspNetCore because I expect it to hit significant issues and I'm more familiar w/ our existing release pipeline for that one.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 7, 2019

@dougbu sounds good!

This was referenced Aug 8, 2019
Closed
Closed
Closed
Closed
Merged
Merged
Merged
dougbu added a commit to dotnet/blazor that referenced this issue Aug 10, 2019
@dougbu
Use Arcade post-build stage template (#1848)
c3a792e 
* Use Arcade post-build stage template
- dotnet/aspnetcore#11924
- enable pipelines publication
  - disable signing checks due to expected issues there
- add validation category
  - doesn't hurt anything to leave this in (for future PRs)
@dougbu
Copy link
Member

dougbu commented Aug 10, 2019

This isn't closed yet. I'm still wrapping up w/ aspnet/AspNetCore

@dougbu dougbu reopened this Aug 10, 2019
dougbu added a commit that referenced this issue Aug 12, 2019
@dougbu
Use stages pipeline
c34e0fd 
- #11924
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `poolName` and `matrix`
  - use `enableMicrobuild`, `enablePublishBuildArtifacts` etc. to simplify YAML scripts
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
@dougbu dougbu mentioned this issue Aug 12, 2019
Merged
dougbu added a commit that referenced this issue Aug 12, 2019
@dougbu
Use stages pipeline
2089fc5 
- #11924
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
dougbu added a commit that referenced this issue Aug 12, 2019
@dougbu
Use stages pipeline
4c3fae8 
- #11924
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
dougbu added a commit that referenced this issue Aug 13, 2019
@dougbu
Use stages pipeline
6707d88 
- #11924
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
dougbu added a commit that referenced this issue Aug 14, 2019
@dougbu
Use stages pipeline
313695b 
- #11924
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
@JunTaoLuo JunTaoLuo assigned JunTaoLuo and wtgodbe and unassigned dougbu Aug 14, 2019
dougbu added a commit that referenced this issue Aug 29, 2019
@dougbu
Use stages pipeline
1a3cc8f 
- #11924
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
dougbu added a commit that referenced this issue Aug 29, 2019
@dougbu
Use stages pipeline
1f498ba 
- #11924
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
dougbu added a commit that referenced this issue Sep 2, 2019
@dougbu
Use stages pipeline
2708b19 
- #11924
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
  - publish in last build step of each job
    - pass more MSBuild properties into builds
  - use distinct `$(AssetManifestFileName)` values per job
    - set global property to override what's hard-coded in Publish.proj
- change codesign-xplat.yml to use empty.proj and normal Arcade signing and publication process
  - remove XPlatPackageSigner.proj
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- add .dll's and .exe's as files to sign w/ Microsoft400
  - add signcheck exclusions
- remove custom manifest generation i.e. the `GenerateBuildAssetManifest` target and related artifacts
  - use regular Arcade publish infrastructure
- update docker infrastructure to use same paths in and out of the container
- correct typo in build.sh

nits:
- upload logs in first artifact
- remove attempts to package non-existent VSIX
  - follow-up to 29cf7ec
- respect verbosity setting in build.sh
- add more information to Artifacts.md
- enable test signing in internal PRs
@JunTaoLuo JunTaoLuo assigned dougbu and unassigned JunTaoLuo and wtgodbe Sep 4, 2019
dougbu added a commit that referenced this issue Sep 4, 2019
@dougbu
Use stages pipeline
b704975 
- #11924
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
  - publish in last build step of each job
    - pass more MSBuild properties into builds
  - use distinct `$(AssetManifestFileName)` values per job
    - set global property to override what's hard-coded in Publish.proj
- change codesign-xplat.yml to use empty.proj and normal Arcade signing and publication process
  - remove XPlatPackageSigner.proj
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- add .dll's and .exe's as files to sign w/ Microsoft400
  - add signcheck exclusions
- remove custom manifest generation i.e. the `GenerateBuildAssetManifest` target and related artifacts
  - use regular Arcade publish infrastructure
- update docker infrastructure to use same paths in and out of the container
- correct typo in build.sh

nits:
- upload logs in first artifact
- remove attempts to package non-existent VSIX
  - follow-up to 29cf7ec
- respect verbosity setting in build.sh
- add more information to Artifacts.md
- enable test signing in internal PRs
dougbu added a commit that referenced this issue Sep 6, 2019
@dougbu
Use stages pipeline
45660ae 
- #11924
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
  - publish in last build step of each job
    - pass more MSBuild properties into builds
  - use distinct `$(AssetManifestFileName)` values per job
    - set global property to override what's hard-coded in Publish.proj
- change codesign-xplat.yml to use empty.proj and normal Arcade signing and publication process
  - remove XPlatPackageSigner.proj
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- add .dll's and .exe's as files to sign w/ Microsoft400
  - add signcheck exclusions
- remove custom manifest generation i.e. the `GenerateBuildAssetManifest` target and related artifacts
  - use regular Arcade publish infrastructure
- update docker infrastructure to use same paths in and out of the container
- correct typo in build.sh

nits:
- upload logs in first artifact
- remove attempts to package non-existent VSIX
  - follow-up to 29cf7ec
- respect verbosity setting in build.sh
- add more information to Artifacts.md
- enable test signing in internal PRs
dougbu added a commit that referenced this issue Sep 8, 2019
@dougbu
Use stages pipeline
b1f31da 
- #11924
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
  - publish in last build step of each job
    - pass more MSBuild properties into builds
  - use distinct `$(AssetManifestFileName)` values per job
    - set global property to override what's hard-coded in Publish.proj
- change codesign-xplat.yml to use empty.proj and normal Arcade signing and publication process
  - remove XPlatPackageSigner.proj
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- add .dll's and .exe's as files to sign w/ Microsoft400
  - add signcheck exclusions
- remove custom manifest generation i.e. the `GenerateBuildAssetManifest` target and related artifacts
  - use regular Arcade publish infrastructure
- update docker infrastructure to use same paths in and out of the container
- correct typo in build.sh

nits:
- upload logs in first artifact
- remove attempts to package non-existent VSIX
  - follow-up to 29cf7ec
- respect verbosity setting in build.sh
- add more information to Artifacts.md
- enable test signing in internal PRs
dougbu added a commit that referenced this issue Sep 9, 2019
@dougbu
Use stages pipeline
c8d386a 
- #11924
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
  - publish in last build step of each job
    - pass more MSBuild properties into builds
  - use distinct `$(AssetManifestFileName)` values per job
    - set global property to override what's hard-coded in Publish.proj
- change codesign-xplat.yml to use empty.proj and normal Arcade signing and publication process
  - remove XPlatPackageSigner.proj
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- add .dll's and .exe's as files to sign w/ Microsoft400
  - add signcheck exclusions
- remove custom manifest generation i.e. the `GenerateBuildAssetManifest` target and related artifacts
  - use regular Arcade publish infrastructure
- update docker infrastructure to use same paths in and out of the container
- correct typo in build.sh

nits:
- upload logs in first artifact
- remove attempts to package non-existent VSIX
  - follow-up to 29cf7ec
- respect verbosity setting in build.sh
- add more information to Artifacts.md
- enable test signing in internal PRs
dougbu added a commit that referenced this issue Sep 9, 2019
@dougbu
Use stages pipeline
4b5ce77 
- #11924
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
  - publish in last build step of each job
    - pass more MSBuild properties into builds
  - use distinct `$(AssetManifestFileName)` values per job
    - set global property to override what's hard-coded in Publish.proj
- change codesign-xplat.yml to use empty.proj and normal Arcade signing and publication process
  - remove XPlatPackageSigner.proj
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- add .dll's and .exe's as files to sign w/ Microsoft400
  - add signcheck exclusions
- remove custom manifest generation i.e. the `GenerateBuildAssetManifest` target and related artifacts
  - use regular Arcade publish infrastructure
- update docker infrastructure to use same paths in and out of the container
- correct typo in build.sh

nits:
- upload logs in first artifact
- remove attempts to package non-existent VSIX
  - follow-up to 29cf7ec
- respect verbosity setting in build.sh
- add more information to Artifacts.md
- enable test signing in internal PRs
dougbu added a commit that referenced this issue Sep 10, 2019
@dougbu
Use stages pipeline
59d84fc 
- #11924
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
  - publish in last build step of each job
    - pass more MSBuild properties into builds
  - use distinct `$(AssetManifestFileName)` values per job
    - set global property to override what's hard-coded in Publish.proj
- change codesign-xplat.yml to use empty.proj and normal Arcade signing and publication process
  - remove XPlatPackageSigner.proj
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- add .dll's and .exe's as files to sign w/ Microsoft400
  - add signcheck exclusions
- remove custom manifest generation i.e. the `GenerateBuildAssetManifest` target and related artifacts
  - use regular Arcade publish infrastructure
- update docker infrastructure to use same paths in and out of the container
- correct typo in build.sh

nits:
- upload logs in first artifact
- remove attempts to package non-existent VSIX
  - follow-up to 29cf7ec
- respect verbosity setting in build.sh
- add more information to Artifacts.md
- enable test signing in internal PRs
dougbu added a commit that referenced this issue Sep 11, 2019
@dougbu
Use stages pipeline (#13040)
04705ee 
- #11924
- change ci.yml to use stages and post-build.yml
  - add use of publish-build-assets.yml and post-build.yml
  - create manifests and push to artifacts in last build step of each job
    - pass more MSBuild properties into those builds
    - use Arcade to publish installers
  - use distinct `$(AssetManifestFileName)` values per job
    - set global property to override what's hard-coded in Publish.proj
- change codesign-xplat.yml to use empty.proj and normal Arcade signing and publication process
  - remove XPlatPackageSigner.proj
- change default-build.yml to use job.yml
  - remove unused parameters e.g. `matrix`, `poolName`, `variables`
  - use `enableMicrobuild` and `enablePublishTestResults` to eliminate duplicate build steps
- add .dll's and .exe's as files to sign w/ Microsoft400
  - add signcheck exclusions
- remove custom manifest generation i.e. the `GenerateBuildAssetManifest` target and related artifacts
- update docker infrastructure to use same paths in and out of the container
  - avoids problems adding to artifacts from within the builds
- correct typo in build.sh
- use `$env:DOTNET_INSTALL_DIR` in `DotNetCommands`
  - relax expectations that an arch-specific folder exists under (say) `$env:DOTNET_HOME`
  - avoids need to define `$env:DOTNET_HOME` in all jobs on CI
- update dependencies from dotnet/arcade build '20190908.2'
  - upgrade to eg. Arcade SDK '1.0.0-beta.19458.2' package version
  - pick up dotnet/arcade@dd593acc8b08 fix
    - enable use of `%(PublishFlatContainer)` metadata and correct signing validation issues
- use `$(DotNetFinalVersionKind)` in preparation for servicing builds
  - set `$(IsStableBuild)` for use in Arcade infrastructure
- disable signing validation for now (see #13864)

nits:
- upload logs in first artifact
- remove attempts to package non-existent VSIX
  - follow-up to 29cf7ec
- respect verbosity setting in build.sh
- add more information to Artifacts.md
- enable test signing in internal PRs
@dougbu
Copy link
Member

dougbu commented Sep 11, 2019

04705ee

@dougbu dougbu closed this as completed Sep 11, 2019
@dougbu dougbu added Done This issue has been fixed and removed area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Sep 11, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
Done This issue has been fixed
Projects
None yet
Milestone
No milestone
3 participants
@JunTaoLuo @dougbu @wtgodbe