Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SDK snapshot tests for 5.0 apps #28489

Closed
1 of 3 tasks
pranavkm opened this issue Dec 7, 2020 · 3 comments · Fixed by dotnet/sdk#23992
Closed
1 of 3 tasks

Add SDK snapshot tests for 5.0 apps #28489

pranavkm opened this issue Dec 7, 2020 · 3 comments · Fixed by dotnet/sdk#23992
Assignees
@pranavkm
Labels
Priority:1 Work that is critical for the release, but we could probably ship without task
Milestone
7.0-preview3

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Dec 7, 2020 •
edited
Loading

This issue tracks adding some tests to verify the SDK does not regress building 5.0 apps

  • Add a test for 5.0 MVC
  • Add a test for 5.0 Blazor Server
  • Add a test for 5.0 Blazor Wasm
@mkArtakMSFT mkArtakMSFT added this to the Next sprint planning milestone Dec 9, 2020
@ghost
Copy link

ghost commented Dec 9, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@captainsafia
Copy link
Member

We've covered this for MVC apps already during the SDK migration but we still need to cover the two Blazor scenarios.

@TanayParikh
Copy link
Contributor

This is entirely testing related, adding to docs & infra.

@mkArtakMSFT mkArtakMSFT added triaged Priority:1 Work that is critical for the release, but we could probably ship without labels Nov 17, 2021
@mkArtakMSFT mkArtakMSFT mentioned this issue Jan 23, 2022
Closed
pranavkm added a commit to dotnet/sdk that referenced this issue Feb 17, 2022
@pranavkm
Add snapshot tests for 5.0 and 6.0 Blazor WASM apps
4e3cf83 
Fixes dotnet/aspnetcore#28489
pranavkm added a commit to dotnet/sdk that referenced this issue Feb 17, 2022
@pranavkm
Add snapshot tests for 5.0 and 6.0 Blazor WASM apps
1e5cde9 
Fixes dotnet/aspnetcore#28489
pranavkm added a commit to dotnet/sdk that referenced this issue Feb 17, 2022
@pranavkm
Add snapshot tests for 5.0 and 6.0 Blazor WASM apps
2bf9b91 
Fixes dotnet/aspnetcore#28489
@pranavkm pranavkm mentioned this issue Feb 17, 2022
Merged
pranavkm added a commit to dotnet/sdk that referenced this issue Feb 18, 2022
@pranavkm
Add snapshot tests for 5.0 and 6.0 Blazor WASM apps (#23992)
6ddde83 
* Add snapshot tests for 5.0 and 6.0 Blazor WASM apps

Fixes dotnet/aspnetcore#28489

* Add baselines for 6.0 tests
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
chsienki pushed a commit to chsienki/razor-compiler that referenced this issue May 20, 2022
@pranavkm
Add snapshot tests for 5.0 and 6.0 Blazor WASM apps (#23992)
b4eb8a3 
* Add snapshot tests for 5.0 and 6.0 Blazor WASM apps

Fixes dotnet/aspnetcore#28489

* Add baselines for 6.0 tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
Priority:1 Work that is critical for the release, but we could probably ship without task
Projects
None yet
Milestone
7.0-preview3
Development

Successfully merging a pull request may close this issue.

Add snapshot tests for 5.0 and 6.0 Blazor WASM apps dotnet/sdk
4 participants
@pranavkm @captainsafia @TanayParikh @mkArtakMSFT