Skip to content

Add snapshot tests for 5.0 and 6.0 Blazor WASM apps #23992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2022

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Feb 17, 2022

Fixes dotnet/aspnetcore#28489

I picked the Blazor WASM hosted as smoke tests to verify we can continue building 5.0 / 6.0 apps. I did not add Blazor Server apps just to avoid enumerating over every scenario and spamming test assets.

@ghost ghost added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Feb 17, 2022
@pranavkm pranavkm requested a review from a team February 17, 2022 17:55
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you might want to consider using the baselines functionality for the tests as is more exhaustive with the published files.

@pranavkm
Copy link
Contributor Author

Are the baslines specific to build tests? I didn't see anything about baselines in the publish tests: https://github.com/dotnet/sdk/blob/main/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmPublishIntegrationTest.cs#L25-L55?

@javiercn
Copy link
Member

I think we might have a bit of overlap in these tests.

@pranavkm pranavkm enabled auto-merge (squash) February 17, 2022 20:48
@pranavkm pranavkm merged commit 6ddde83 into main Feb 18, 2022
@marcpopMSFT marcpopMSFT deleted the prkrishn/add_snapshot_tests branch May 9, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SDK snapshot tests for 5.0 apps
2 participants