-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Open
Labels
affected-very-fewThis issue impacts very few customersThis issue impacts very few customersarea-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkseverity-nice-to-haveThis label is used by an internal toolThis label is used by an internal tool
Milestone
Description
Depends on NuGet/Home#7342.
Follow up to #4178
The packages we ship which reference the shared framework should be built using FrameworkReference
. Once NuGet/Home#7342 is resolved, the metadata for this item will be preserved in the nuspec, which should ensure consumers get all the necessary runtime settings and compiler references.
Workaround
Consumers using our AspNetCore packages, such as Microsoft.AspNetCore.NodeServices, need to make sure they also have <FrameworkReference Include="Microsoft.AspNetCore.App" />
. This will be implicitly added with Microsoft.NET.Sdk.Web, but not other MSBuild SDKs.
Changes required
- We need to change our own packages to build with
FrameworkReference
. (Related work Convert projects in this repo to use ProjectReference #4246) - Update our SDK in BuildTools to support using
FrameworkReference
opheoHeidrich
Metadata
Metadata
Assignees
Labels
affected-very-fewThis issue impacts very few customersThis issue impacts very few customersarea-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkseverity-nice-to-haveThis label is used by an internal toolThis label is used by an internal tool