Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default EventSourceSupport to true in ASP.NET Native AOT apps #48247

Closed
eerhardt opened this issue May 15, 2023 · 2 comments · Fixed by dotnet/sdk#32538
Closed

Default EventSourceSupport to true in ASP.NET Native AOT apps #48247

eerhardt opened this issue May 15, 2023 · 2 comments · Fixed by dotnet/sdk#32538
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework NativeAOT
Milestone

Comments

@eerhardt
Copy link
Member

EventSource wasn't supported when publishing an app for NativeAOT in .NET 7. This led to the EventSourceSupport feature switch to being disabled by default in AOT.

In .NET 8 we are getting EventSource to work in Native AOT apps - dotnet/runtime#79241. However, the EventSourceSupport feature switch is still disabled, so users won't be able to use things like dotnet monitor or dotnet counters unless they explicitly opt-in.

We should default EventSourceSupport=true in ASP.NET Native AOT'd applications.

This will add size to the default apps (the estimate is around 1 MB), however the tradeoff is worth it, since EventSource is a very common mechanism used for getting information about a running app.

cc @DamianEdwards @davidfowl @noahfalk @agocke @LakshanF @jkotas @MichalStrehovsky

@ghost ghost added the NativeAOT label May 15, 2023
@eerhardt eerhardt added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework NativeAOT and removed area-runtime NativeAOT labels May 15, 2023
@eerhardt eerhardt added this to the 8.0-preview5 milestone May 15, 2023
@davidfowl
Copy link
Member

Agree

@agocke
Copy link
Member

agocke commented May 16, 2023

No argument from me for ASP.NET. For hello, world I think it would ~double the app size, so there seems like a good reason to leave it out there.

eerhardt added a commit to eerhardt/sdk that referenced this issue May 23, 2023

Verified

This commit was signed with the committer’s verified signature.
@ghost ghost locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework NativeAOT
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants