Use Arcade version suffixes for local (3.0.0-dev) and PR builds (3.0.0-ci) #10279
Conversation
natemcmaster
requested review from
analogrelay,
BrennanConroy,
halter73,
mikaelm12,
ryanbrandenburg and
SteveSandersonMS
as code owners
| @@ -40,15 +40,17 @@ | |||
| <BuildNumberSuffix>$(_BuildNumberShortDate)-$(VersionSuffixBuildOfTheDayPadded)</BuildNumberSuffix> | |||
|
|
|||
| <FileRevisionVersion>$(_BuildNumberShortDate)</FileRevisionVersion> | |||
| <VersionSuffix>$(PreReleaseLabel)-$(BuildNumberSuffix)</VersionSuffix> | |||
There was a problem hiding this comment.
Would changing the dash to a period resolve the format difference in releases between AspNetCoreRuntime.3.0.x64.3.0.0-preview-19081-0488 and Microsoft.Extensions.Logging.3.0.0-preview5.19227.9 ?
There was a problem hiding this comment.
Yes it would resolve the format difference, but it would create more problems. See #4339
There was a problem hiding this comment.
That issue was written before we moved to include the preview number in our versions. So, we could make the switch when we next update the branding in this repo. Suggest reopening #4339.
There was a problem hiding this comment.
Re opened. I'll bring it up during our area-platform triage. It's not really a build team decision to do this or not because this impacts the appearance and behavior of the product, so I won't attempt to address that in this PR.
Eilon
added
the
area-infrastructure
natemcmaster
changed the title
Part of #7280 (Convert to Arcade)
This updates our versioning to better match Arcades https://github.com/dotnet/arcade/blob/master/Documentation/CorePackages/Versioning.md
Effective changes
Everything else should remain the same