Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the test input a bit more reasonable #11067

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Conversation

pranavkm
Copy link
Contributor

No description provided.

@pranavkm pranavkm requested review from dougbu and sebastienros June 10, 2019 23:59
@analogrelay analogrelay added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 11, 2019
@dougbu
Copy link
Member

dougbu commented Jun 11, 2019

@pranavkm what's the context here? How does changing the test input make its execution less flaky?

@sebastienros
Copy link
Member

This is not a valid French number on Linux apparently. Maybe should file another issue on corefx?

@dougbu
Copy link
Member

dougbu commented Jun 11, 2019

This is not a valid French number on Linux apparently. Maybe should file another issue on corefx?

I've filed similar issues in the past. CoreFx generally relies on the underlying platform for globalization information. You would probably just get a redirect to ICU (https://github.com/unicode-org/icu and http://site.icu-project.org/) -- the Ubuntu component providing number formats (I think). If the information isn't in there, it's in CLDR (http://cldr.unicode.org/index).

More generally, feel free to let someone know France is more forgiving than something thinks (about numbers).

@pranavkm
Copy link
Contributor Author

I'll file an issue with CoreFx. That said, jQuery Validation does not allow it, neither does browser validation (browsers remove spaces if you paste in a number with spaces). I'm questioning the need for MVC to test for validating numbers with spaces in them.

@pranavkm pranavkm merged commit 1ffc235 into master Jun 11, 2019
@ghost ghost deleted the prkrishn/fixup-test branch June 11, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants