-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the test input a bit more reasonable #11096
Conversation
cc @aspnet/build. We made this change in master: #11067. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine. @Pilchie this is a test-only fix, so is this a "tell" for shiproom? Might be good to review the related corefx bug in more detail to see if there is a customer-facing issue here, too.
CoreFx bug for reference: https://github.com/dotnet/corefx/issues/38455 |
That's my understanding. You can merge (since the branch is open) but email |
Yep, and I'll bring it up with CoreFx folks in shiproom today. Can someone give me details on the environments where we're seeing problems? |
This comment was made automatically. If there is a problem contact aspnetcore-build@microsoft.com. I've triaged the above build. I've created/commented on the following issue(s) |
@Pilchie the issue is specific to Ubuntu machines. I reproduced this on 16.04, but it's the libicu64 version that surfaces it. |
Thanks - we're good to go ahead and merge when you're ready. |
@aspnet/build this is good to merge now. |
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/2626