Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the test input a bit more reasonable #11096

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm requested a review from mkArtakMSFT June 11, 2019 16:38
@pranavkm
Copy link
Contributor Author

cc @aspnet/build. We made this change in master: #11067.

Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. @Pilchie this is a test-only fix, so is this a "tell" for shiproom? Might be good to review the related corefx bug in more detail to see if there is a customer-facing issue here, too.

@pranavkm
Copy link
Contributor Author

CoreFx bug for reference: https://github.com/dotnet/corefx/issues/38455

@analogrelay
Copy link
Contributor

this is a test-only fix, so is this a "tell" for shiproom?

That's my understanding. You can merge (since the branch is open) but email netcoreship with the PR and brief context (couple of sentences) of the fix.

@analogrelay analogrelay added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 11, 2019
@Pilchie
Copy link
Member

Pilchie commented Jun 11, 2019

Yep, and I'll bring it up with CoreFx folks in shiproom today. Can someone give me details on the environments where we're seeing problems?

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact aspnetcore-build@microsoft.com.

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2181

@pranavkm
Copy link
Contributor Author

@Pilchie the issue is specific to Ubuntu machines. I reproduced this on 16.04, but it's the libicu64 version that surfaces it.

@Pilchie
Copy link
Member

Pilchie commented Jun 11, 2019

Thanks - we're good to go ahead and merge when you're ready.

@pranavkm
Copy link
Contributor Author

@aspnet/build this is good to merge now.

@mkArtakMSFT mkArtakMSFT merged commit d805ee1 into release/2.1 Jun 11, 2019
@ghost ghost deleted the prkrishn/fixup-test branch June 11, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants