Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail on startup for Http/2 HTTPS on Mac #11120

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Fail on startup for Http/2 HTTPS on Mac #11120

merged 3 commits into from
Jun 13, 2019

Conversation

Tratcher
Copy link
Member

#11061 Testing via Helix

@Tratcher Tratcher added this to the 3.0.0-preview7 milestone Jun 11, 2019
@Tratcher Tratcher self-assigned this Jun 11, 2019
@Tratcher
Copy link
Member Author

It worked, and failed a bunch of other tests like Templates.Test.GrpcTemplateTest.GrpcTemplate 😁.

@Tratcher Tratcher requested a review from JunTaoLuo June 12, 2019 17:21
@Tratcher Tratcher marked this pull request as ready for review June 12, 2019 17:21
ryanbrandenburg
ryanbrandenburg approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go once the ProjectTemplate test either uses OSSkipCondition or checks the behavior that was changed here.

@Tratcher Tratcher merged commit 82d2b4f into master Jun 13, 2019
@Tratcher Tratcher deleted the tratcher/no2mac branch June 13, 2019 22:42
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

@analogrelay analogrelay Awaiting requested review from analogrelay

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
3.0.0-preview7
Development

Successfully merging this pull request may close these issues.
4 participants
@Tratcher @ryanbrandenburg @analogrelay @amcasey