Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating resx files is broken #11054

Closed
natemcmaster opened this issue Jun 10, 2019 · 2 comments
Closed

Generating resx files is broken #11054

natemcmaster opened this issue Jun 10, 2019 · 2 comments
Assignees
@JunTaoLuo
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed

Comments

@natemcmaster
Copy link
Contributor

As a result of #10674, the /t:Resx target is missing from projects.

To fix this, we need to set <GenerateResxSource>true</GenerateResxSource> to take advantage of Arcade's RESX feature, and delete the .Designer.cs files from source.
@natemcmaster
Copy link
Contributor Author

See https://github.com/dotnet/arcade/blob/master/Documentation/ArcadeSdk.md#generateresxsource-bool

We should probably also set <GenerateResxSourceEmitFormatMethods>true</GenerateResxSourceEmitFormatMethods>

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 10, 2019
@natemcmaster natemcmaster mentioned this issue Jun 12, 2019
Closed
21 tasks
Tratcher added a commit that referenced this issue Jun 12, 2019
@Tratcher
Use automatic resx #11054
6a29a6f
Tratcher added a commit that referenced this issue Jun 13, 2019
@Tratcher
Fail on startup for Http/2 HTTPS on Mac #11061 (#11120)
82d2b4f 
* Use automatic resx #11054
@JunTaoLuo
Copy link
Contributor

FYI, some repos won't be able to convert due to: dotnet/arcade#3244.

@JunTaoLuo JunTaoLuo mentioned this issue Jul 15, 2019
Merged
@JunTaoLuo JunTaoLuo added Done This issue has been fixed and removed Working labels Jul 18, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Eilon @JunTaoLuo @natemcmaster