Always produce a .zip and .tar.gz for the targeting pack #11230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
approved these changes
Jun 14, 2019
| WorkingDirectory="$(TargetingPackLayoutRoot)" | ||
| Condition="'$(TargetRuntimeIdentifier)' == 'linux-x64'" /> | ||
| <Message Importance="High" Text="$(MSBuildProjectName) -> $(ArchiveOutputPath)" /> | ||
| Command="tar -czf $(TarArchiveOutputPath) ." |
There was a problem hiding this comment.
Woah we have tar on windows now?
There was a problem hiding this comment.
dougbu
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
Looks good.
Side question: Why did you originally made the change at https://github.com/aspnet/AspNetCore/pull/11116/files#diff-7936f6109f5f7b8cb12969aa87896bf4R66 ?
To decouple build and pack. We still need to build the .dlls for the ref pack because there is rid-specific packaging, like .deb and .rpm files, but otherwise, a rid-specific build doesn't need to produce the rid-less packaging (.nupkg/.zip/.tar.gz) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11116