Skip to content

Add option for only packing runtime-specific packages #11116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 12, 2019
Merged

Add option for only packing runtime-specific packages #11116

merged 7 commits into from
Jun 12, 2019

Conversation

natemcmaster
Copy link
Contributor

A necessary code-cleanup to prepare for #7280

@natemcmaster natemcmaster requested a review from a team as a code owner June 11, 2019 22:21
@natemcmaster natemcmaster requested a review from JunTaoLuo June 11, 2019 22:21
@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 11, 2019
@natemcmaster natemcmaster changed the title Add option for only packing specific packages Add option for only packing runtime-specific packages Jun 12, 2019
@natemcmaster
Copy link
Contributor Author

🆙 📅 it turns out there where several places that depended IsPackable=true, which probably shouldn't have. I've updated to make the following changes:

  • Suppress producing Microsoft.AspNetCore.Blazor.Templates.dll. This was a dummy .dll file which was getting packed into the Blazor VSIX, even though it contained no code
  • Decouple some build targets from IsPackable=true that shouldn't have depended on it
  • Fixup ANCMSymbols

@natemcmaster natemcmaster merged commit 6c806f9 into master Jun 12, 2019
@ghost ghost deleted the namc/platform-only branch June 12, 2019 03:47
This was referenced Jun 14, 2019
Merged
Merged
@SteveSandersonMS SteveSandersonMS mentioned this pull request Jul 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

@analogrelay analogrelay Awaiting requested review from analogrelay

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natemcmaster @dougbu @Eilon