Skip to content

Generate .nupkg files that contain aspnetcore-runtime MSI for insertion into Visual Studio #11345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 25, 2019

Conversation

jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Jun 18, 2019

Part of #11071

Packages will be put in the NonShipping folder and uploaded to the blob store.

@johnbeisner what do we need to do to verify this E2E?

@jkotalik jkotalik requested a review from a team June 18, 2019 20:24
@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 18, 2019
@jkotalik jkotalik closed this Jun 18, 2019
@jkotalik jkotalik reopened this Jun 18, 2019
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please wait to hear back from @johnbeisner before merging

@johnbeisner
Copy link
Contributor

@jkotalik
You should go to the VS feed and download/inspect at the existing Asp.NET NuPkgs for VS:
https://devdiv.visualstudio.com/DevDiv/_packaging?_a=feed&feed=VS

If you filter on "VS.Redist.Common.AspNet" you will see your team's VS NuPkgs - I feel we should stay with these naming/ID/versioning conventions at least thru the first insertion of 3.0 SDK into VS.

@johnbeisner
Copy link
Contributor

johnbeisner commented Jun 19, 2019

@jkotalik
"what do we need to do to verify this E2E?"

  1. produce an official Asp.NET build with the NuPkgs
  2. upload the four 3.0 NuPkgs to the VS feed
  3. Modify the current VS insertion PR to consume these new Asp.NET NuPkgs
    https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/186888

I can handle steps 2 & 3; eventually we will need to automate step 2.

@jkotalik jkotalik force-pushed the jkotalik/nupkgSharedFramework branch from 12878cf to 4cf3ca2 Compare June 19, 2019 19:16
@jkotalik
Copy link
Contributor Author

Need to figure out how to ignore signing this package.

@johnbeisner
Copy link
Contributor

johnbeisner commented Jun 20, 2019

@jkotalik
@joeloff
Pretty sure the MSIs need to be signed.

@joeloff
Copy link
Member

joeloff commented Jun 20, 2019

The nupkg is just a delivery mechanism for getting external binaries into the VS build. As long as the MSIs are signed, we're good. The nupkg signature doesn't matter. It can either be signed or unsigned.

@jkotalik
Copy link
Contributor Author

Chatted with @joeloff offline. The SignTool only signs nuget packages in the Build Windows Installers (not msis). Msis are signed in a separate step within the wixprojs themselves. This is the first time we are including a msi within a nuget package, so we should ignore trying to sign it. Also, we shouldn't attempt to sign it too as then we could have multiple msis with the same binaries with different signatures.

I'll verify that the contents are in fact signed. Unfortunately, this either would mean I need to make an internal PR or push and verify after I pushed.

@jkotalik jkotalik force-pushed the jkotalik/nupkgSharedFramework branch from bb1fc64 to c9c7846 Compare June 25, 2019 03:47
@jkotalik jkotalik merged commit 0274ace into master Jun 25, 2019
@ghost ghost deleted the jkotalik/nupkgSharedFramework branch June 25, 2019 20:41
@johnbeisner
Copy link
Contributor

@jkotalik
I do not see the NuPkgs at blob storage - could I be looking at the wrong versions?

@jkotalik
Copy link
Contributor Author

jkotalik commented Jul 1, 2019

I see it being uploaded. It should be on the aspnet-aspnetcore feed. Example build version number: VS.Redist.Common.AspNetCore.SharedFramework.x64.3.0.3.0.0-preview7.19351.4.nupkg and internal build.
https://dev.azure.com/dnceng/internal/_build/results?buildId=245648&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants