-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Generate .nupkg files that contain aspnetcore-runtime MSI for insertion into Visual Studio #11345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Installers/Windows/SharedFramework/SharedFrameworkPackage.nuspec
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but please wait to hear back from @johnbeisner before merging
@jkotalik If you filter on "VS.Redist.Common.AspNet" you will see your team's VS NuPkgs - I feel we should stay with these naming/ID/versioning conventions at least thru the first insertion of 3.0 SDK into VS. |
@jkotalik
I can handle steps 2 & 3; eventually we will need to automate step 2. |
12878cf
to
4cf3ca2
Compare
Need to figure out how to ignore signing this package. |
The nupkg is just a delivery mechanism for getting external binaries into the VS build. As long as the MSIs are signed, we're good. The nupkg signature doesn't matter. It can either be signed or unsigned. |
Chatted with @joeloff offline. The SignTool only signs nuget packages in the Build Windows Installers (not msis). Msis are signed in a separate step within the wixprojs themselves. This is the first time we are including a msi within a nuget package, so we should ignore trying to sign it. Also, we shouldn't attempt to sign it too as then we could have multiple msis with the same binaries with different signatures. I'll verify that the contents are in fact signed. Unfortunately, this either would mean I need to make an internal PR or push and verify after I pushed. |
bb1fc64
to
c9c7846
Compare
src/Installers/Windows/SharedFramework/SharedFrameworkPackage.nuspec
Outdated
Show resolved
Hide resolved
src/Installers/Windows/TargetingPack/TargetingPackPackage.nuspec
Outdated
Show resolved
Hide resolved
src/Installers/Windows/TargetingPack/TargetingPackPackage.nuspec
Outdated
Show resolved
Hide resolved
src/Installers/Windows/SharedFramework/SharedFrameworkPackage.nuspec
Outdated
Show resolved
Hide resolved
src/Installers/Windows/TargetingPack/TargetingPackPackage.nuspec
Outdated
Show resolved
Hide resolved
@jkotalik |
I see it being uploaded. It should be on the aspnet-aspnetcore feed. Example build version number: VS.Redist.Common.AspNetCore.SharedFramework.x64.3.0.3.0.0-preview7.19351.4.nupkg and internal build. |
Part of #11071
Packages will be put in the NonShipping folder and uploaded to the blob store.
@johnbeisner what do we need to do to verify this E2E?