Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate VS nuget package for 2.1 #11616

Merged
merged 10 commits into from
Jul 16, 2019
Merged

Generate VS nuget package for 2.1 #11616

merged 10 commits into from
Jul 16, 2019

Conversation

jkotalik
Copy link
Contributor

Fixes #11071. This will also be in 2.2 once we merge up.

@jkotalik jkotalik requested a review from a team June 26, 2019 20:14
@Eilon Eilon added the feature-installers Includes: Installers label Jun 26, 2019
@jkotalik
Copy link
Contributor Author

Builds are here: http://aspnetci/viewLog.html?buildId=659155&buildTypeId=Releases_21Public_WindowsInstallers&tab=artifacts#!fk6iluux85. Only difference is that the Major and Minor versions are actually set 😄

dougbu
dougbu approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anurse I suggest we at least let Shiproom know before merging this. I suspect we're done building 2.x for the next releases and that this will need to wait 'til August.

src/Installers/Windows/SharedFramework/SharedFramework.wixproj Outdated Show resolved Hide resolved
@dougbu
Copy link
Member

dougbu commented Jun 26, 2019

Note: I'm approving because the fix looks fine but do not merge without additional authorization

@analogrelay
Copy link
Contributor

analogrelay commented Jun 27, 2019 •
edited
Loading

The branches are ✔️ Open ✔️ now!

@analogrelay analogrelay added the Servicing-consider Shiproom approval is required for the issue label Jul 9, 2019
@analogrelay analogrelay added this to the 2.1.x milestone Jul 9, 2019
jkotalik and others added 2 commits July 10, 2019 10:16
@jkotalik @analogrelay
Update src/Installers/Windows/SharedFramework/SharedFrameworkPackage.…
74d3cf6 
…nuspec

Co-Authored-By: Andrew Stanton-Nurse <andrew@stanton-nurse.com>
@jkotalik @analogrelay
Update src/Installers/Windows/SharedFramework/SharedFrameworkPackage.…
2409bef 
…nuspec

Co-Authored-By: Andrew Stanton-Nurse <andrew@stanton-nurse.com>
@vivmishra vivmishra added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jul 10, 2019
@vivmishra vivmishra modified the milestones: 2.1.x, 2.1.13 Jul 10, 2019
@jkotalik
Copy link
Contributor Author

@anurse feel free to merge this whenever 😄

@analogrelay analogrelay merged commit 010fdea into release/2.1 Jul 16, 2019
@ghost ghost deleted the jkotalik/21nugetSharedFramework branch July 16, 2019 15:26
@jkotalik jkotalik mentioned this pull request Jul 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@analogrelay analogrelay analogrelay approved these changes

Assignees
No one assigned
Labels
feature-installers Includes: Installers Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
2.1.13
Development

Successfully merging this pull request may close these issues.
5 participants
@jkotalik @dougbu @analogrelay @Eilon @vivmishra