Johluo/migrate more tooling #22294
Merged
Johluo/migrate more tooling #22294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to reorganization, this source code was found in https://github.com/aspnet/Razor/tree/dotnet/aspnetcore-tooling@582f3f867eeb8fca00e6b328faf7665c9a98476c \n\nCommit migrated from dotnet/razor@33b287d
This commit enables us to initialize projects with the correct file kind, thus allowing mixed views and components in the same project. This isn't hooked up to MSBuild yet, so for now nothing will initialize this code with the correct file kind. \n\nCommit migrated from dotnet/razor@7216d18
- Removed the differences of workspace project and `HostProject` in regards to `ProjectSnapshotManager` methods. We now just have `ProjectAdded`, `ProjectRemoved` etc. - Obsoleted Workspace related members from the `ProjectSnapshot`in order to ensure that current LiveShare continues to work. Once LiveShare has been incorporated into Razor we can remove these members from the project snapshot. - Removed several TagHelper calculating logic pieces from the document tracker. This is now done entirely from the ProjectSnapshotManager so there's no secondary route that needs to be taken in order to resolve TagHelpers for VS windows cases. - Updated the `ProjectState` to take in TagHelpers and removed the internal logic it had to resolve TagHelpers. - Added a TagHelpers property to ProjectSnapshot to indicate that they're no longer calculated, they're part of the project inputs. - Added a ProjectWorkspaceChange generator to be responsible for calculating any workspace related information that is needed for a `ProjectSnapshot`. For now, this just calculates TagHelpers but in the future it may do more. - Added a `FilePathComparison` static helper class which acts similarly to `FilePathComparer`. - Changed our dynamic file info provider to no longer care about `ProjectIds`. Before this, it kept track of the project ids internally but never used them so this is a noop functional change. - Changed how the out of process remote TagHelper resolution flow works. Prior to this you'd pass a Project across the wire as part of a project snapshot handle and then resolve TagHelpers the old fashioned way. - Updated all existing tests to respect the new `ProjectWorkspaceState` flows. - Added tests for new APIs. dotnet/razor#6672 \n\nCommit migrated from dotnet/razor@a562164
\n\nCommit migrated from dotnet/razor@5af7556
\n\nCommit migrated from dotnet/razor@ef2f897
\n\nCommit migrated from dotnet/razor@ce9f141
\n\nCommit migrated from dotnet/razor@408b123
\n\nCommit migrated from dotnet/razor@f547905
- There's nothing specific about the TagHelperResolver that needs to be bound to VS. Moving it to the workspaces assembly so it can be used by VSCode. - Also changed the `TagHelperResolver` to be an `IWorkspaceService`. \n\nCommit migrated from dotnet/razor@9f73afe
\n\nCommit migrated from dotnet/razor@cdafa55
\n\nCommit migrated from dotnet/razor@84066bc
\n\nCommit migrated from dotnet/razor@2765324
- Flow Root namespace through in command line builds - Flow Root namespace through in design time builds - Feedback\n\nCommit migrated from dotnet/razor@057d4f3
- Obsoleted old `GetItem` API. - Updated tests to take new API. - Added a new test to verify the broken scenario. dotnet/razor#8972 \n\nCommit migrated from dotnet/razor@2dd34b8
\n\nCommit migrated from dotnet/razor@986c224
) Serialize project state to project.razor.json\n\nCommit migrated from dotnet/razor@fef50ba
Also address some lingering feedback
|
Note for reviewers, only the commits 68fea5b and newer are "interesting". The rest are just migrated commits. |
pranavkm
approved these changes
May 28, 2020
dougbu
approved these changes
May 28, 2020
| @@ -149,7 +149,7 @@ stages: | |||
| $(_InternalRuntimeDownloadArgs) | |||
| displayName: Build x86 | |||
|
|
|||
| # This is in a separate build step with to workaround MAX_PATH limitations - https://github.com/Microsoft/msbuild/issues/53 | |||
| # This is in a separate build step with -forceCoreMsbuild to workaround MAX_PATH limitations - https://github.com/Microsoft/msbuild/issues/53 | |||
|
InputDateInteractsWithEditContext_NonNullableDateTime in https://dev.azure.com/dnceng/public/_build/results?buildId=661903&view=logs&jobId=6c33d704-163a-5170-38fa-caa7bc99f17c looks like a flaky test @pranavkm @SteveSandersonMS @javiercn, can you confirm whether that's the case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to #21581. As @NTaylorMullen noted in dotnet/razor#1933, there are some more projects that should be moved to aspnetcore which were not mentioned in the original docs.