[automated] Merge branch 'release/3.1' => 'main' #31656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-maestro-bot
requested review from
BrennanConroy,
halter73,
jkotalik,
Tratcher and
a team
as code owners
dotnet-maestro-bot
force-pushed
the
merge/release/3.1-to-main
branch
from
7cf381d
to
13a34c6
Compare
ghost
added
area-infrastructure
ghost
added
tell-mode
pranavkm
reviewed
Apr 13, 2021
| @@ -154,13 +154,15 @@ protected void AddAndCheckConsumedBytes(long consumedBytes) | |||
|
|
|||
| protected ValueTask<ReadResult> StartTimingReadAsync(ValueTask<ReadResult> readAwaitable, CancellationToken cancellationToken) | |||
| { | |||
|
|
|||
| if (!readAwaitable.IsCompleted && _timingEnabled) | |||
| if (!readAwaitable.IsCompleted) | |||
| @@ -61,7 +61,7 @@ export class HttpConnection implements IConnection { | |||
| private transport?: ITransport; | |||
| private startInternalPromise?: Promise<void>; | |||
| private stopPromise?: Promise<void>; | |||
| private stopPromiseResolver!: (value?: PromiseLike<void>) => void; | |||
| private stopPromiseResolver: (value?: PromiseLike<void>) => void = () => {}; | |||
There was a problem hiding this comment.
@BrennanConroy do we need to bring these changes over from 3.1 -> main?
There was a problem hiding this comment.
Should already be in main
dotnet-maestro-bot
requested review from
dougbu,
javiercn and
a team
as code owners
pranavkm
force-pushed
the
merge/release/3.1-to-main
branch
from
626f671
to
b13d652
Compare
pranavkm
force-pushed
the
merge/release/3.1-to-main
branch
from
b13d652
to
87326bc
Compare
mkArtakMSFT
removed
the
community-contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I detected changes in the release/3.1 branch which have not been merged yet to main. I'm a robot and am configured to help you automatically keep main up to date, so I've opened this PR.
This PR merges commits made on release/3.1 by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/3.1-to-main'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
or if you are using SSH
Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.