Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move System.ComponentModel.Annotations To Manual Dependency Update #32468

Merged
merged 2 commits into from
May 6, 2021

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented May 6, 2021

It's not possible to remove this dependency (#32447) so making it so we no longer try to automatically update it. With automated updates enabled, it's leading to a 'stale' dependency tree as this package uses a commit that's different from the rest of our dotnet/runtime ingestion.

@TanayParikh TanayParikh requested a review from dougbu as a code owner May 6, 2021 16:54
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 6, 2021
@TanayParikh TanayParikh enabled auto-merge (squash) May 6, 2021 16:54
@dougbu
Copy link
Member

dougbu commented May 6, 2021

/fyi @dotnet/aspnet-build

@dougbu
Copy link
Member

dougbu commented May 6, 2021

also /fyi @BrennanConroy

@Pilchie
Copy link
Member

Pilchie commented May 6, 2021

Why do we have a pinned dependency for this in the first place? This doesn't seem to be one of the dead-ended packages?

@TanayParikh TanayParikh merged commit 73d9fa9 into main May 6, 2021
@TanayParikh TanayParikh deleted the taparik/manualComponentModelAnnotations branch May 6, 2021 19:21
@ghost ghost added this to the 6.0-preview5 milestone May 6, 2021
@TanayParikh
Copy link
Contributor Author

Automerged before I could address the comment.

Why do we have a pinned dependency for this in the first place? This doesn't seem to be one of the dead-ended packages?

The dependency was no longer being updated, I didn't see any recent packages for it either. @dougbu do you know if it is in fact EOL?

@dougbu
Copy link
Member

dougbu commented May 6, 2021

Must have been EOL'ed fairly recently. 6.0.0-preview.5.21227.3 remains the newest package version in the dotnet6 feed even though e.g. System.Text.Json is at 6.0.0-preview.5.21256.5. @Anipik @ericstj is that correct❔

@dougbu
Copy link
Member

dougbu commented May 6, 2021

@Anipik and @ericstj, should we be pinning the 5.0.0 version of this package to get the latest and greatest assembly when targeting netstandard2.0 or net461❔ We shouldn't use the 6.0.0-preview.5.21227.3 version when we get to RTM.

@Pilchie
Copy link
Member

Pilchie commented May 6, 2021

Also tagging @ViktorHofer as the author of dotnet/runtime#51891

@ericstj
Copy link
Member

ericstj commented May 6, 2021

@ViktorHofer removed this package with dotnet/runtime#51891.

should we be pinning the 5.0.0 version of this package

Yes

@ghost
Copy link

ghost commented May 6, 2021

Hi @ericstj. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

TanayParikh added a commit that referenced this pull request May 6, 2021
TanayParikh added a commit that referenced this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants