-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move System.ComponentModel.Annotations
To Manual Dependency Update
#32468
Conversation
/fyi @dotnet/aspnet-build |
also /fyi @BrennanConroy |
Why do we have a pinned dependency for this in the first place? This doesn't seem to be one of the dead-ended packages? |
Automerged before I could address the comment.
The dependency was no longer being updated, I didn't see any recent packages for it either. @dougbu do you know if it is in fact EOL? |
Also tagging @ViktorHofer as the author of dotnet/runtime#51891 |
@ViktorHofer removed this package with dotnet/runtime#51891.
Yes |
Hi @ericstj. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Based on discussion in #32468 due to dead-ending in dotnet/runtime#51891
Based on discussion in #32468 due to dead-ending in dotnet/runtime#51891
It's not possible to remove this dependency (#32447) so making it so we no longer try to automatically update it. With automated updates enabled, it's leading to a 'stale' dependency tree as this package uses a commit that's different from the rest of our dotnet/runtime ingestion.