Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead end System.ComponentModel.Annotations package #51891

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Dead end System.ComponentModel.Annotations package #51891

merged 1 commit into from
Apr 27, 2021

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 26, 2021 •
edited
Loading

Nearly all configurations in the System.ComponentModel.Annotations
package weren't built live anymore and just redistributed from older
packages. Except for the netstandard2.1 configuration, the package
didn't receive any changes.

As the library is exposed as part of the shared framework, a
reference to the package on .NETCoreApp isn't necessary and will
be ignored by the SDK. Because of that, there's no strong reason to
keep evolving the library on netstandard2.1 which doesn't support
.NET Framework.

Dead-ending the package to remove the burden
of maintaining the harvesting of old configurations.

Contributes to #47530

@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Apr 26, 2021
@ViktorHofer ViktorHofer requested a review from ericstj April 26, 2021 20:50
@ViktorHofer ViktorHofer self-assigned this Apr 26, 2021
@ghost
Copy link

ghost commented Apr 26, 2021

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Nearly all configurations in the System.ComponentModel.Annotations
package weren't built live anymore and just redistributed from older
packages. Except for the netstandard2.0 configuration, the package
didn't receive any changes. As the library is exposed as part of the
shared framework, a reference to the package on .NETCoreApp isn't
necessary and will be ignored by the SDK.

Based on these reasons, dead-ending the package to remove the burden
of maintaining the harvesting of old configurations.

Contributes to #47530

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-System.ComponentModel
Milestone: 6.0.0

@ViktorHofer
Dead end System.ComponentModel.Annotations package
061a4af 
Nearly all configurations in the System.ComponentModel.Annotations
package weren't built live anymore and just redistributed from older
packages. Except for the netstandard2.0 configuration, the package
didn't receive any changes. As the library is exposed as part of the
shared framework, a reference to the package on .NETCoreApp isn't
necessary and will be ignored by the SDK.

Based on these reasons, dead-ending the package to remove the burden
of maintaining the harvesting of old configurations.

Contributes to dotnet#47530
@ViktorHofer ViktorHofer force-pushed the ComponentModelAnnotations branch from 2ec4e87 to 061a4af Compare April 26, 2021 20:55
@ViktorHofer ViktorHofer requested a review from ajcvickers April 26, 2021 21:22
@ghost
Copy link

ghost commented Apr 26, 2021

Tagging subscribers to this area: @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

Nearly all configurations in the System.ComponentModel.Annotations
package weren't built live anymore and just redistributed from older
packages. Except for the netstandard2.1 configuration, the package
didn't receive any changes.

As the library is exposed as part of the shared framework, a
reference to the package on .NETCoreApp isn't necessary and will
be ignored by the SDK. Because of that, there's no strong reason to
keep evolving the library on netstandard2.1 which doesn't support
.NET Framework.

Dead-ending the package to remove the burden
of maintaining the harvesting of old configurations.

Contributes to #47530

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-System.ComponentModel.DataAnnotations
Milestone: 6.0.0

@ericstj
Copy link
Member

ericstj commented Apr 26, 2021 •
edited
Loading

This seems OK. We're unlikely to want to modify any API in netstandard2.0 ref for this assembly since it's all typeforwards to inbox types in .NETFramework which we can't change. By dead-ending the package we're preventing ourselves from shipping brand-new types on netstandard frameworks, but that's OK. Those can always be done in a different assembly.

@ViktorHofer ViktorHofer mentioned this pull request Apr 27, 2021
Closed
25 tasks
@ViktorHofer
Copy link
Member Author

Formatting leg failure is #51943.
OSX failure is #30056.
Checking out took far too long on the Mono crossaot Product Build Linux x64 release leg. Likely a very slow network at that time and not actionable.

@ViktorHofer ViktorHofer merged commit 3de9cda into dotnet:main Apr 27, 2021
@ViktorHofer ViktorHofer deleted the ComponentModelAnnotations branch April 27, 2021 17:48
@Pilchie Pilchie mentioned this pull request May 6, 2021
Merged
TanayParikh added a commit to dotnet/aspnetcore that referenced this pull request May 6, 2021
@TanayParikh
Downgrade System.ComponentModel.Annotations to 5.0.0
fd81287 
Based on discussion in #32468 due to dead-ending in dotnet/runtime#51891
@TanayParikh TanayParikh mentioned this pull request May 6, 2021
Merged
TanayParikh added a commit to dotnet/aspnetcore that referenced this pull request May 7, 2021
@TanayParikh
Downgrade System.ComponentModel.Annotations to 5.0.0 (#32484)
883476d 
Based on discussion in #32468 due to dead-ending in dotnet/runtime#51891
@lukas-lansky lukas-lansky mentioned this pull request May 25, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@ericstj ericstj ericstj approved these changes

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees

@ViktorHofer ViktorHofer

Labels
area-System.ComponentModel.DataAnnotations
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ViktorHofer @ericstj @ajcvickers @safern