Add tests for WebApplicationFactory<T> issues with minimal hosting #33890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-mvc
martincostello
commented
Jun 27, 2021
| } | ||
|
|
||
| [Fact] | ||
| [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33889")] |
There was a problem hiding this comment.
I wasn't sure if this was the right syntax or not for a test known to be failing due to an active issue so it gets ignored and doesn't break the build.
martincostello
added a commit
to martincostello/aspnetcore
that referenced
this pull request
Jun 27, 2021
Miscellaneous style and code analyzer fixes from things Visual Studio was complaining to me about while I was working on dotnet#33890.
pranavkm
pushed a commit
that referenced
this pull request
Jun 28, 2021
Miscellaneous style and code analyzer fixes from things Visual Studio was complaining to me about while I was working on #33890.
|
@martincostello we typically don't add these types of tests. I'll let @davidfowl handle this, since he's been active in the area. |
Add unit tests that replicate dotnet#33876 and dotnet#33889.
martincostello
force-pushed
the
WebApplicationFactoryT-Issues
branch
from
ab0ee4a to
d5c606f
Compare
|
I think I understand these issues now. |
|
Superseded by #34794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Add tests for
WebApplicationFactory<T>issues.PR Description
Add unit tests that replicate #33876 and #33889.