Apply hosting environment via command line args #34794
Conversation
- This makes sure that the entire applicaton can see changes to host configuration (env, content root etc). - Added tests to verify those scenarios
ghost
added
the
area-mvc
davidfowl
added
old-area-web-frameworks-do-not-use
| { | ||
| var config = new[] | ||
| { | ||
| KeyValuePair.Create("Greeting", "Bonjour tout le monde"), |
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. |
| // Transform the host configuration into command line arguments | ||
| foreach (var (key, value) in _hostConfiguration.AsEnumerable()) | ||
| { | ||
| args.Add($"--{key}={value}"); |
There was a problem hiding this comment.
Do we need to do any fancy escaping for value? Like can values have spaces which would break config parsing? I'm not super familiar with this area
There was a problem hiding this comment.
I don't see how it breaks given how the parsing works. We're not parsing the command line string, we're parsing each arg.
I also don't see a way to escape - or / so that might be the only problem.
There was a problem hiding this comment.
An = in the key would also mess this up, right? I'm not sure how realistic that is.
There was a problem hiding this comment.
I also don't see a way to escape - or / so that might be the only problem.
You could always base64 encode/decode. Stripping and adding back the = padding characters might be a pain though.
There was a problem hiding this comment.
I think we wait until somebody hits this then we fix it by supporting escape sequences in the command line configuration provider, the problem is general.
src/Mvc/test/Mvc.FunctionalTests/SimpleWithWebApplicationBuilderTests.cs
Outdated
Show resolved
Hide resolved
amcasey
added
the
area-minimal
Fixes #33889