Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop running Components E2E Tests in Quarantined Test Pipelines #37891

Merged
merged 4 commits into from
Oct 29, 2021
Merged

Stop running Components E2E Tests in Quarantined Test Pipelines #37891

merged 4 commits into from
Oct 29, 2021

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Oct 28, 2021 •
edited
Loading

Stops running the components E2E tests for the aspnetcore-quarantined-tests and aspnetcore-quarantined-pr pipelines.

Also disables the E2EMigrationTests from the CI.

Fixes #37443

@TanayParikh TanayParikh added area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Oct 28, 2021
@TanayParikh TanayParikh marked this pull request as ready for review October 28, 2021 04:39
@TanayParikh TanayParikh requested review from a team as code owners October 28, 2021 04:39
@TanayParikh
Copy link
Contributor Author

TanayParikh commented Oct 28, 2021 •
edited
Loading

The E2ETestMigration PlayWright tests are not run as part of the components-e2e-test pipeline.

What should we do with those tests. Options:

  1. Keep running the PlayWright tests in the quarantine pipelines
  2. Move the PlayWright tests to the components-e2e-test pipeline
  3. Disable the PlayWright tests from the CI for now

I'd normally go with #2, but given we aren't actively working on the PlayWright tests (as far as I know), and given they're duplicates of the existing E2E tests, I was considering #3.

cc/ @HaoK @captainsafia

@TanayParikh
Copy link
Contributor Author

I'd normally go with #2, but given we aren't actively working on the playright tests (as far as I know), and given they're duplicates of the existing E2E tests, I was considering #3.

Spoke with @HaoK offline, disabling the E2EMigrationTest for now from the CI (via e162edb). We can revisit this at a later stage.

TanayParikh
TanayParikh commented Oct 29, 2021
View reviewed changes
src/Components/test/E2ETestMigration/Microsoft.AspNetCore.Components.Migration.E2ETests.csproj
Comment on lines +15 to +17
<!-- Skip the Components E2ETestMigration in CI -->
<SkipTests Condition="'$(ContinuousIntegrationBuild)' == 'true'">true</SkipTests>
<BuildHelixPayload>false</BuildHelixPayload>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #37929 to track re-enabling these tests in the CI once the PlayWright tests are ready.

@TanayParikh TanayParikh merged commit 0835032 into main Oct 29, 2021
@TanayParikh TanayParikh deleted the taparik/skipE2EEInQuarantinedPipelines branch October 29, 2021 17:17
@ghost ghost added this to the 7.0-preview1 milestone Oct 29, 2021
@TanayParikh TanayParikh mentioned this pull request Nov 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.

[Blazor] Disable running components E2E tests on Quarantined tests pipeline
2 participants
@TanayParikh @pranavkm