Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop running Components E2E Tests in Quarantined Test Pipelines #37891

Merged
merged 4 commits into from
Oct 29, 2021
Merged

Stop running Components E2E Tests in Quarantined Test Pipelines #37891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7711a4
Fixes https://github.com/dotnet/aspnetcore/issues/37443
TanayParikh Oct 28, 2021
8daf8a1
CI -> ContinuousIntegrationBuild
TanayParikh Oct 28, 2021
e162edb
Skip E2EMigration Tests in CI
TanayParikh Oct 28, 2021
08cff89
Exclude Migration Tests from Helix
TanayParikh Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .azure/pipelines/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,6 @@ stages:
cancelTimeoutInMinutes: 30
buildArgs: -all -pack -test -binaryLog /p:SkipHelixReadyTests=true /p:SkipIISNewHandlerTests=true /p:SkipIISTests=true
/p:SkipIISExpressTests=true /p:SkipIISNewShimTests=true /p:RunTemplateTests=false
/p:SkipComponentsE2ETests=true
$(_InternalRuntimeDownloadArgs)
beforeBuild:
- powershell: "& ./src/Servers/IIS/tools/UpdateIISExpressCertificate.ps1; & ./src/Servers/IIS/tools/update_schema.ps1"
Expand All @@ -669,7 +668,7 @@ stages:
agentOs: macOS
timeoutInMinutes: 240
isAzDOTestingJob: true
buildArgs: --all --test --binaryLog "/p:RunTemplateTests=false /p:SkipComponentsE2ETests=true /p:SkipHelixReadyTests=true" $(_InternalRuntimeDownloadArgs)
buildArgs: --all --test --binaryLog "/p:RunTemplateTests=false /p:SkipHelixReadyTests=true" $(_InternalRuntimeDownloadArgs)
beforeBuild:
- bash: "./eng/scripts/install-nginx-mac.sh"
displayName: Installing Nginx
Expand All @@ -690,7 +689,7 @@ stages:
agentOs: Linux
isAzDOTestingJob: true
useHostedUbuntu: false
buildArgs: --all --test --binaryLog "/p:RunTemplateTests=false /p:SkipComponentsE2ETests=true /p:SkipHelixReadyTests=true" $(_InternalRuntimeDownloadArgs)
buildArgs: --all --test --binaryLog "/p:RunTemplateTests=false /p:SkipHelixReadyTests=true" $(_InternalRuntimeDownloadArgs)
beforeBuild:
- bash: "./eng/scripts/install-nginx-linux.sh"
displayName: Installing Nginx
Expand Down Expand Up @@ -722,7 +721,7 @@ stages:
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log $(_InternalRuntimeDownloadArgs)
displayName: Restore interop projects
- script: ./eng/build.cmd -ci -nobl -noBuildRepoTasks -noRestore -test -all -noBuildNative -projects eng\helix\helix.proj
/p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true /p:SkipComponentsE2ETests=true
/p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log $(_InternalRuntimeDownloadArgs)
displayName: Run build.cmd helix target
env:
Expand Down
2 changes: 2 additions & 0 deletions .azure/pipelines/components-e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ pr:
variables:
- name: DOTNET_SKIP_FIRST_TIME_EXPERIENCE
value: true
- name: EXECUTE_COMPONENTS_E2E_TESTS
value: true
- name: _TeamName
value: AspNetCore

Expand Down
4 changes: 2 additions & 2 deletions src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
<SkipTests Condition="'$(SeleniumE2ETestsSupported)' != 'true'">true</SkipTests>
<SkipTests Condition="'$(SeleniumE2ETestsSupported)' == 'true'">false</SkipTests>

<!-- Until we resolve reliability issues, we're disabling these E2E tests in the main CI job -->
<SkipTests Condition="'$(SkipComponentsE2ETests)' == 'true'">true</SkipTests>
<!-- Skip the Components E2E tests in CI unless explicitly configured otherwise via EXECUTE_COMPONENTS_E2E_TESTS -->
<SkipTests Condition="'$(ContinuousIntegrationBuild)' == 'true' and '$(EXECUTE_COMPONENTS_E2E_TESTS)' != 'true'">true</SkipTests>

<!-- Tests do not work on Helix or when bin/ directory is not in project directory due to undeclared dependency on test content. -->
<BaseOutputPath />
Expand Down
6 changes: 5 additions & 1 deletion ...omponents/test/E2ETestMigration/Microsoft.AspNetCore.Components.Migration.E2ETests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@

<TestTrimmedApps Condition="'$(ContinuousIntegrationBuild)' == 'true'">true</TestTrimmedApps>
<TestTrimmedApps Condition="'$(Configuration)' == 'Release'">true</TestTrimmedApps>


<!-- Skip the Components E2ETestMigration in CI -->
<SkipTests Condition="'$(ContinuousIntegrationBuild)' == 'true'">true</SkipTests>
<BuildHelixPayload>false</BuildHelixPayload>
Comment on lines +15 to +17
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #37929 to track re-enabling these tests in the CI once the PlayWright tests are ready.


<BuildInParallel>false</BuildInParallel>
</PropertyGroup>

Expand Down