[WIP] Obsoleting Pseudo-header public APIs #42199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendeny cycle strikes again
…genkin/obsoleting-pseudoheader-public-api
davidfowl
reviewed
Jun 15, 2022
| @@ -61,6 +63,8 @@ public static class HeaderNames | |||
| public static readonly string AltSvc = "Alt-Svc"; | |||
|
|
|||
| /// <summary>Gets the <c>:authority</c> HTTP header name.</summary> | |||
| [Obsolete("For infrastructure use only", false)] | |||
| [EditorBrowsable(EditorBrowsableState.Never)] | |||
There was a problem hiding this comment.
We shouldn't hide it from intellisense. That's one of the most annoying experiences as a developer when you see it in the docs and then it doesn't show up in the IDE. Obsoletion is enough
|
Closing as I found a way more elegant solution than trying to fix this cyclic dependency |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we place the pseudo-headers in the
HeaderNames.csfile which exposes them as public API. This is redundant as the pseudo-headers are all stripped out in internal code prior to passing it up to publicly available layers. Thus, these headers cannot actually be used by end users. This PR marks them as obsolete, removes them from intellisense and adds them to an internal-only file,PseudoHeaderNames.cs.