Remove Pseudo-Headers From Public API #42496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new internal ones in PseudoHeaderNames.cs
… ones instead. Then updated all usages
Daniel-Genkin-MS-2
requested review from
Tratcher,
halter73,
BrennanConroy,
JamesNK and
Pilchie
as code owners
Tratcher
reviewed
Jun 30, 2022
… Core to avoid the internal dependencies
halter73
reviewed
Jul 6, 2022
halter73
requested changes
Jul 6, 2022
There was a problem hiding this comment.
Thanks! This looks good.
For APIs that people actually used, we should start using diagnostic IDs for obsoletions. See https://github.com/dotnet/designs/blob/main/accepted/2020/better-obsoletion/better-obsoletion.md. I don't think it's necessary for this though because these header names have never been populated in header dictionaries.
Tratcher
reviewed
Jul 7, 2022
halter73
approved these changes
Jul 11, 2022
ghost
added this to the 
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we place the pseudo-headers in the
HeaderNames.csfile which exposes them as public API. This is redundant as the pseudo-headers are all stripped out in internal code prior to passing it up to publicly available layers. Thus, these headers cannot actually be used by end users. This PR marks them as obsolete and adds them to an internal-only file,PseudoHeaderNames.cs.From: #42002 (comment)