[release/7.0] Update spa-templates to ref new 7.0 branch #44134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- just created release/7.0 in dotnet/spa-templates - use it here to enable main in spa-templates to get new branding - also use latest commit from spa-templates - contains a fix for [[C&AI Translation Feedback] - ASP.NET Core incomplete German translation](https://dev.azure.com/ceapex/CEINTL/_workitems/edit/710128)
dougbu
added
Servicing-consider
|
Hi @dougbu. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
wtgodbe
approved these changes
Sep 22, 2022
dougbu
added
the
area-mvc
|
In case it's not obvious, the [C&AI Translation Feedback] - ASP.NET Core incomplete German translation fix is in the dotnet/spa-templates repo but that doesn't affect what we ship until the submodule is updated here. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dougbu
added
Servicing-approved
|
Approved in email |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[release/7.0] Update spa-templates to ref new 7.0 branch
Description
Contains a fix for [C&AI Translation Feedback] - ASP.NET Core incomplete German translation. #43956 brings in fixes for the templates in dotnat/aspnetcore for that bug too (more on that when that loc handback PR is in main and ready for backporting).
Customer Impact
Without this fix, customer would see
Target net7.0instead ofZiel net7.0when in a German locale and using one of the templates from Microsoft.DotNet.Web.Spa.ProjectTemplates.7.0.Regression?
Microsoft.DotNet.Web.Spa.ProjectTemplates.6.0 only had translations for the name and description of the two templates from dotnet/spa-templates. This change here completes filling that gap.
Risk
One-word changes in existing language-specific files 😃
Verification
Packaging changes reviewed?