Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2021196

[dotnet-bot]

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/ceLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

[brunolins16]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[brunolins16]

I have followed the steps, reported here #43599 (comment), and based on that we still not done yet:

OneLocBuildClient.exe Information: 0 : In summary, 99% localized for 27 resource files.

https://dev.azure.com/dnceng/internal/_build/results?buildId=1994592&view=logs&j=c0636702-cad1-5e4d-7b5b-f15c1cce530a&t=ef3c2779-04f6-5216-b20f-460f31132ece&l=983

@dougbu Is my assumption correct?

[dougbu]

Is my assumption correct?

Yes. Bit more work to do here unfortunately.

I also checked the ToLocalizeResources.csv file produced in this morning's aspnetcore-localize build. That shows only a few of the remaining 128 strings are hardcoded values like [BundleNameSub] that should be excluded from localization.

[dougbu]

@wtgodbe and @joeloff am I correct that an ampersand in a .wxl file identifies the next character as an accelerator key❔ If yes, is this changed translation an improvement❔

@cristianosuzuki77 what are the heuristics the translators use to decide where to place the accelerator key❔

[wtgodbe]

I don't actually know, I haven't worked on generating one of these before

[dougbu]

I found a few mentions of accelerator / accessibility keys in WiX and it seems the toolkit follows the conventions of other Windows installers. An ampersand identifies the key.

The bundle already has mid-word accelerators in a few strings e.g. https://github.com/dotnet/aspnetcore/pull/43956/files#diff-ff840b97875d2e933bba46b993fed4078e0fb5b6abd097e87d7b8a4b10b0e517R22 (though none in the English strings that I noticed).

So, is changing the accelerator key from A to u a good idea❔ It's consistent across Cancel buttons in this language and a few other accelerator keys are changing e.g. https://github.com/dotnet/aspnetcore/pull/43956/files#diff-4d0161edbccd7dd3b1576f2c6530fb898b0dc60e46169d1082700cc89e04b81dR36 and https://github.com/dotnet/aspnetcore/pull/43956/files#diff-5be1b04c80c351d6cb288862f266fbc0e6e82eeed53d0094a9979c48d7935072R54. I am just not sure why and hope to hear from @cristianosuzuki77.

[dougbu]

Opened https://ceapex.visualstudio.com/CEINTL/_workitems/edit/709046

[dougbu]

This has been resolved. Leaving it open only to provide fodder for a release note. /cc @ldillonel

[Tratcher]

Is this ready?

[dougbu]

No, this isn't ready. That's because the OneLocBuild task shows the translation work is incomplete (see below) and some wording is changing. @mkArtakMSFT has volunteered to check the Russian but we haven't got people looking at the rest.

We also need to have a conversation between the leads about whether to request the loc team to leave the accelerator / accessibility / hot keys alone. See above and https://ceapex.visualstudio.com/CEINTL/_workitems/edit/709046 for details.

---

OneLocBuildClient.exe Information: 0 : [src\Installers\Windows\SharedFrameworkBundle\thm.wxl] 95% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\Installers\Windows\WindowsHostingBundle\Strings.wxl] 94% localized for 13 languages.
OneLocBuildClient.exe Information: 0 : [src\Installers\Windows\WindowsHostingBundle\thm.wxl] 98% localized for 13 languages.

(These numbers won't reach 100% w/o some exclusions for e.g. [BundleNameSub] but https://dev.azure.com/dnceng/_apis/resources/Containers/11824184/Loc?itemPath=Loc%2FToLocalizeResources.csv shows real work remains. I'm working on an exclusions PR.)

[dougbu]

I still see a few "translations" that are reverting to English in the WXL files. We're not quite ready to merge this or propose the fixes for 7.0.0.

@mkArtakMSFT how do the Russian updates look to you so far❔

@sebastienros if you have time, could you scan the French changes and let us know if the new translations aren't regressions (even better if they're better 😄)❔

@dotnet/aspnet-admins, @danmoseley do we have others on the team w/ fluency who could scan another language❔ @cristianosuzuki77 already looked at the Italian and pronounced it good.

[dougbu]

This has been resolved. Leaving it open only to provide fodder for a release note. /cc @ldillonel

[dougbu]

Opened [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, some Chinese translations contain extra spaces covering the typos I commented on.

Will likely have to file another loc issue because ToLocalizeResources.csv hasn't changed in at least a week and shows simple strings like "Installation Successfully Completed". Any known issues blocking the work @jonfortescue @cristianosuzuki77❔

On the upside, files now contain fixes for problems from earlier loc PRs:

• [C&AI Translation Feedback] - ASP.NET Core incorrect translation
• [C&AI Translation Feedback] - ASP.NET Core incomplete German translation

[dougbu]

Do not merge (yet)

Blocked on completion of ticket 717656 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, under-translation of "directory" though ToLocResources.csv indicates all strings are completely translated.

[dougbu]

I think we're sufficiently unblocked to take this. While three loc issues remain open and the hot keys are changing in problematic ways, we can touch things up e.g. undoing all hot key changes when backporting to release/7.0.

I reactivated ticket 717656 [C&AI Translation Feedback] - LCL-JUNO-PROD-ASPNETCORE, under-translation of "directory" because "directory" is still not translated in src/Installers/Windows/SharedFrameworkBundle/1031/thm.wxl. We have the correct translation in src/Installers/Windows/WindowsHostingBundle/1031/thm.wxl or the old version of src/Installers/Windows/SharedFrameworkBundle/1031/thm.wxl to make that touch-up easy.