-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Backport loc fixes #44576
Merged
dougbu
merged 2 commits into
dotnet:release/7.0
from
dougbu:dougbu/localization.backport/7.0
Oct 17, 2022
Merged
[release/7.0] Backport loc fixes #44576
dougbu
merged 2 commits into
dotnet:release/7.0
from
dougbu:dougbu/localization.backport/7.0
Oct 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nition ID 1159: Build ID 2021196 - backport dotnet#43956 aka 1b19eaf * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1991692 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1994592 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1995899 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2001161 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2001161 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2004653 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2006380 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2008465 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2009172 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2010258 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2011272 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2012502 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2018734 * Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2019976 - Fixes [loc ticket 710128 [C&AI Translation Feedback] - ASP.NET Core incomplete German translation](https://ceapex.visualstudio.com/CEINTL/_queries/edit/710128/) - Fixes dotnet#44167 - Automates translation of WXL files
- restore German "directory" translation - undo hot key changes - leave only Portuguese s/&Navegar/&Procurar/ change for Options browse button - apparently, that's something like s/to browse/to search for/
dougbu
added
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
feature-installers
Includes: Installers
feature-templates
labels
Oct 16, 2022
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
|
Reviewers: Just waiting for one of you to approve 😁 |
javiercn
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
feature-installers
Includes: Installers
feature-templates
Servicing-approved
Shiproom has approved the issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[release/7.0] Backport loc fixes
Backport automated localization improvements from main.
Description
[directory]
not shown in installation bundle help #44167OptionsBrowseButton
Customer Impact
Without these changes, translated strings are not at the quality level we could and should achieve. The ASP.NET Core localization sign-off for .NET 7.0 is (or, at least, should be) contingent on merging these new strings.
Regression?
WiX localized strings have been fairly consistent since 3.1.0.
Risk
Updates affect only the localized strings shown in
Verification
Rather thorough code inspection, especially of the French, Italian, and Russian translations. I'm also hoping @richaverma1's team will have time to run a few of the bundle installers for additional validation.
Packaging changes reviewed?