Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Backport loc fixes #44576

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Oct 16, 2022

[release/7.0] Backport loc fixes

Backport automated localization improvements from main.

Description

Customer Impact

Without these changes, translated strings are not at the quality level we could and should achieve. The ASP.NET Core localization sign-off for .NET 7.0 is (or, at least, should be) contingent on merging these new strings.

Regression?

  • Yes
  • No

WiX localized strings have been fairly consistent since 3.1.0.

Risk

  • High
  • Medium
  • Low

Updates affect only the localized strings shown in

  • Shared Framework Bundle installers
  • Windows Hosting Bundle installers
  • German project templates, their "Target net7.0" translation in particular
  • a Simplified Chinese project template, a typo in "OpenAPI" in particular

Verification

  • Manual (required)
  • Automated

Rather thorough code inspection, especially of the French, Italian, and Russian translations. I'm also hoping @richaverma1's team will have time to run a few of the bundle installers for additional validation.

Packaging changes reviewed?

  • Yes
  • No
  • N/A

dotnet-bot and others added 2 commits October 15, 2022 21:29
…nition ID 1159: Build ID 2021196

- backport dotnet#43956 aka 1b19eaf

* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1991692
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1994592
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 1995899
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2001161
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2001161
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2004653
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2006380
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2008465
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2009172
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2010258
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2011272
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2012502
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2018734
* Localized file check-in by OneLocBuild Task: Build definition ID 1159: Build ID 2019976

- Fixes [loc ticket 710128 [C&AI Translation Feedback] - ASP.NET Core incomplete German translation](https://ceapex.visualstudio.com/CEINTL/_queries/edit/710128/)
- Fixes dotnet#44167
- Automates translation of WXL files
- restore German "directory" translation
- undo hot key changes
  - leave only Portuguese s/&Navegar/&Procurar/ change for Options browse button
  - apparently, that's something like s/to browse/to search for/
@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers feature-templates labels Oct 16, 2022
@dougbu dougbu requested a review from a team October 16, 2022 04:37
@dougbu dougbu requested a review from a team as a code owner October 16, 2022 04:37
@ghost
Copy link

ghost commented Oct 16, 2022

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@dougbu
Copy link
Member Author

dougbu commented Oct 16, 2022

I'll add servicing template tomorrow done and approved

@dougbu dougbu added the Servicing-approved Shiproom has approved the issue label Oct 16, 2022
@dougbu dougbu enabled auto-merge (squash) October 16, 2022 21:01
@dougbu
Copy link
Member Author

dougbu commented Oct 16, 2022

Reviewers: Just waiting for one of you to approve 😁

@dougbu dougbu merged commit 083257b into dotnet:release/7.0 Oct 17, 2022
@dougbu dougbu deleted the dougbu/localization.backport/7.0 branch October 17, 2022 12:39
@dougbu dougbu added this to the 7.0.0 milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers feature-templates Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants