http.sys (6.0 backport): new option for response buffering #48072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# {PR title}
HttpSys: new option for response buffering
## Description
{Detail}
As per [old PR 418](aspnet/HttpSysServer#418) (direct copy), enables kernel mode response-buffering in http.sys - with modification to use app-context switch rather than public API change
## Customer Impact
Without this buffer, writes are sent as-written direct thru http.sys; this has two problems:
- fragmentation if writes are small
- issues with latency
## Regression?
- [ ] Yes
- [x] No
[If yes, specify the version the behavior has regressed from]
## Risk
- [ ] High
- [ ] Medium
- [x] Low - opt in, no impact to consumers not using this flag
[Justify the selection above]
## Verification
- [x] Manual (required) - will try to verify with internal MSFT consumer (targeting net6.0)
- [ ] Automated
## Packaging changes reviewed?
- [ ] Yes
- [ ] No
- [x] N/A
----
## When servicing release/2.1
- [ ] Make necessary changes in eng/PatchConfig.props
mgravell
requested review from
Tratcher,
halter73 and
BrennanConroy
as code owners
|
Hi @mgravell. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Tratcher
approved these changes
May 4, 2023
11 tasks
Co-authored-by: Aditya Mandaleeka <adityamandaleeka@users.noreply.github.com>
|
@wtgodbe for servicing when possible |
|
Tactics mail sent, awaiting approval. |
|
Approved. |
|
Hi @mgravell. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
JamesNK
requested changes
May 6, 2023
JamesNK
approved these changes
May 8, 2023
|
Components failure is known/unrelated |
ghost
added
the
area-infrastructure
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpSys: new option for response buffering
8.0 feature: #47776
(note: this is a cherry-pick from the internal experimental/validation environment)
Description
As per old PR 418 (direct copy), enables kernel mode response-buffering in http.sys - with modification to use app-context switch rather than public API change
Customer Impact
Without this buffer, writes are sent as-written direct thru http.sys; this has two problems:
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
When servicing release/2.1