Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.sys (6.0 backport): new option for response buffering #48072

Merged
merged 2 commits into from
May 8, 2023

Commits on May 4, 2023

  1. Merged PR 30089: HttpSys: new option for response buffering

    # {PR title}
    
    HttpSys: new option for response buffering
    
    ## Description
    
    {Detail}
    
    As per [old PR 418](aspnet/HttpSysServer#418) (direct copy), enables kernel mode response-buffering in http.sys - with modification to use app-context switch rather than public API change
    
    ## Customer Impact
    
    Without this buffer, writes are sent as-written direct thru http.sys; this has two problems:
    
    - fragmentation if writes are small
    - issues with latency
    
    ## Regression?
    
    - [ ] Yes
    - [x] No
    
    [If yes, specify the version the behavior has regressed from]
    
    ## Risk
    
    - [ ] High
    - [ ] Medium
    - [x] Low - opt in, no impact to consumers not using this flag
    
    [Justify the selection above]
    
    ## Verification
    
    - [x] Manual (required) - will try to verify with internal MSFT consumer (targeting net6.0)
    - [ ] Automated
    
    ## Packaging changes reviewed?
    
    - [ ] Yes
    - [ ] No
    - [x] N/A
    
    ----
    
    ## When servicing release/2.1
    
    - [ ] Make necessary changes in eng/PatchConfig.props
    Marc Gravell authored and mgravell committed May 4, 2023
    Configuration menu
    Copy the full SHA
    ea52899 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Update src/Servers/HttpSys/src/HttpSysOptions.cs

    Co-authored-by: Aditya Mandaleeka <adityamandaleeka@users.noreply.github.com>
    mgravell and adityamandaleeka authored May 5, 2023
    Configuration menu
    Copy the full SHA
    4d4ce88 View commit details
    Browse the repository at this point in the history