Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Microsoft.CodeAnalysis package changes in prebuilt baseline #48212

Merged
merged 2 commits into from
May 12, 2023
Merged

Revert Microsoft.CodeAnalysis package changes in prebuilt baseline #48212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
049ea4d
Remove Microsoft.CodeAnalysis packages from allowed prebuilts
mthalman May 12, 2023
7c13dbf
Adding back original versions before https://github.com/dotnet/aspnet…
mthalman May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions eng/SourceBuildPrebuiltBaseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,15 @@

<!-- These are what the analyzers are built against. They are overridden in full source build.
It may be possible to generate SBRPs -->
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.Analyzers/*2.9.4*" />
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.AnalyzerUtilities/*3.3.0*" />
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.Analyzers*" />
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.Common*" />
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.CSharp*" />
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.CSharp.Workspaces*" />
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.Workspaces.Common*" />
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.Common/*3.3.1*" />
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.CSharp/*3.3.1*" />
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.CSharp.Workspaces/*3.3.1*" />
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.Workspaces.Common/*3.3.1*" />
Comment on lines +16 to +19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these 3.3.1 packages also be in SBRP?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @mmitche, these are executed at build time so we don't want them in SBRP since those are reference implementation only.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I think we may be getting into a corner, eventually. We may end up with packages that should be SBRPs for some repos, and not SBRPs for others. @dotnet/source-build-internal Has this happened before?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may end up with packages that should be SBRPs for some repos, and not SBRPs for others.

We have had the case where a reference package satisfies on repo's requirements but not another because it is loaded. In those cases the repo that loads the assembly would need to use a live/current version.

<UsagePattern IdentityGlob="System.Composition/*1.0.31*" />
<UsagePattern IdentityGlob="System.Threading.Tasks.Extensions/*4.5.3*" />

<!-- Added to unblock dependency flow, needs review. -->
<UsagePattern IdentityGlob="System.Security.Cryptography.Xml/*6.0.0*" />

Expand Down