Revert Microsoft.CodeAnalysis package changes in prebuilt baseline #48212
Conversation
ghost
added
the
area-infrastructure
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
mthalman
changed the title
| <UsagePattern IdentityGlob="Microsoft.CodeAnalysis.Common/*3.3.1*" /> | ||
| <UsagePattern IdentityGlob="Microsoft.CodeAnalysis.CSharp/*3.3.1*" /> | ||
| <UsagePattern IdentityGlob="Microsoft.CodeAnalysis.CSharp.Workspaces/*3.3.1*" /> | ||
| <UsagePattern IdentityGlob="Microsoft.CodeAnalysis.Workspaces.Common/*3.3.1*" /> |
There was a problem hiding this comment.
Should these 3.3.1 packages also be in SBRP?
There was a problem hiding this comment.
According to @mmitche, these are executed at build time so we don't want them in SBRP since those are reference implementation only.
There was a problem hiding this comment.
Yeah. I think we may be getting into a corner, eventually. We may end up with packages that should be SBRPs for some repos, and not SBRPs for others. @dotnet/source-build-internal Has this happened before?
There was a problem hiding this comment.
We may end up with packages that should be SBRPs for some repos, and not SBRPs for others.
We have had the case where a reference package satisfies on repo's requirements but not another because it is loaded. In those cases the repo that loads the assembly would need to use a live/current version.
|
@mthalman This PR looks good to me. We plan on upgrading our M.CA dependencies soon in order to complete some feature work and I want to get a sense of what the process should be in order to play nice with source build. If we want to upgrade to M.CA to 4.6.0 we would need to:
For 4, do we need to make any changes in the SDK? |
I would reverse the order a bit:
I don't think any changes would be necessary in installer. |
The changes that were made to the prebuilt baseline in #48179 can be reverted now that SBRPs for the offending packages have been defined in dotnet/source-build-reference-packages#666 and been flowed into aspnetcore.