Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.CodeAnalysis prebuilts in aspnetcore #3434

Closed
MichaelSimons opened this issue May 11, 2023 · 4 comments
Closed

Microsoft.CodeAnalysis prebuilts in aspnetcore #3434

MichaelSimons opened this issue May 11, 2023 · 4 comments
Assignees
@mthalman
Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball untriaged

Comments

@MichaelSimons
Copy link
Member

Latest internal CI build is reporting a number of Microsoft.CodeAnalysis prebuilts coming from aspnetcore.

Microsoft.CodeAnalysis.Analyzers.3.3.3
Microsoft.CodeAnalysis.Common.4.5.0
Microsoft.CodeAnalysis.CSharp.4.5.0

Looks like new SBRPs are needed. When fixing a follow-up is to determine why these were not caught within the aspnetcore repo's source build leg that has prebuilt detection enabled.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-prebuilts Reducing the number of prebuilt packages in the tarball untriaged labels May 11, 2023
@MichaelSimons MichaelSimons moved this to 8.0 Preview 5 in .NET Source Build May 11, 2023
@mthalman mthalman mentioned this issue May 11, 2023
Merged
@MichaelSimons MichaelSimons moved this from 8.0 Preview 5 to In Progress in .NET Source Build May 11, 2023
@mthalman
Copy link
Member

Caused from the changes in dotnet/aspnetcore#48179.

@mthalman
Copy link
Member

Corresponding PR in aspnetcore to clean up prebuilt baseline: dotnet/aspnetcore#48212

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build May 12, 2023
@eerhardt
Copy link
Member

Do we also need this line for aspnetcore now?

https://github.com/dotnet/installer/blob/6a56c14821feb79f515315895c9a70b3ab8658a6/src/SourceBuild/content/repo-projects/runtime.proj#L46

We only have these 2:

https://github.com/dotnet/installer/blob/6a56c14821feb79f515315895c9a70b3ab8658a6/src/SourceBuild/content/repo-projects/aspnetcore.proj#L44-L45

We are trying to follow the same pattern for our Source Generator as what the runtime repo does.

@mthalman
Copy link
Member

Yeah, I think so. You still need to be pinned to an older version due to the mismatch between the SDK version in the aspnetcore repo versus the installer repo, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mthalman mthalman

Labels
area-prebuilts Reducing the number of prebuilt packages in the tarball untriaged
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MichaelSimons @eerhardt @mthalman