-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin M.CA dependency versions used in RDG #48179
Conversation
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
I prefer dotnet/installer#16318 (comment) if it's fast enough, it's more of a stage0 SDK issue than an aspnetcore issue (cc @mmitche) |
I'd prefer both. I like the value that we get out of being able to control what version we build against in the event that this happens in the future. |
I also prefer both. I like that we get a consistent experience in and out of source-build. No surprises. |
Looks like you need to follow https://github.com/dotnet/source-build/blob/main/Documentation/eliminating-pre-builts.md#allowed-exceptions dotnet/runtime's Regex source generator is already using this version (4.5.0), so it should be OK to use it in source-build. FYI - @mthalman |
eng/Versions.props
Outdated
@@ -229,6 +229,7 @@ | |||
--> | |||
<Analyzer_MicrosoftCodeAnalysisCSharpVersion>3.3.1</Analyzer_MicrosoftCodeAnalysisCSharpVersion> | |||
<Analyzer_MicrosoftCodeAnalysisCSharpWorkspacesVersion>3.3.1</Analyzer_MicrosoftCodeAnalysisCSharpWorkspacesVersion> | |||
<RDG_MicrosoftCodeAnalysisVersion>4.5.0</RDG_MicrosoftCodeAnalysisVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<RDG_MicrosoftCodeAnalysisVersion>4.5.0</RDG_MicrosoftCodeAnalysisVersion> | |
<MicrosoftCodeAnalysisVersion_LatestVS>4.5.0</MicrosoftCodeAnalysisVersion_LatestVS> |
Can we follow the same naming pattern as https://github.com/dotnet/runtime/blob/main/eng/Versions.props#LL71C6-L71C43?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add a comment above this line explaining. It would be better here than in the Generator.csproj
I went ahead and updated the existing exemptions we had for M.CA dependencies to remove the version pin. I noticed that the runtime repo is extremely liberal about what is exempt so I assume not being picky about version numbers is fine. |
I don't think dotnet/runtime has the "pre-built" checks working yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me
Requested review from Matt for the prebuilt baseline update |
Resolves (🤞🏽) issues in dotnet/installer#16318