Refactor Components.Browser package #5166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,113 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
The Components-CSharp template is redundant now, since the Razor Components template is now in the .Templating project.
Now was a good time to remove it from here, since it saved me the trouble of updating it to match the new dependency names.
24 tasks
javiercn
approved these changes
Dec 18, 2018
…t.AspNetCore.Blazor. Delete redundant Components-CSharp template (it now ships from Templating).
…AssemblyRenderer.
SteveSandersonMS
force-pushed
the
stevesa/refactor-components-browser-package
branch
from
ea1f363 to
a9baa17
Compare
SteveSandersonMS
deleted the
stevesa/refactor-components-browser-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Microsoft.AspNetCore.Components.Browserserved two purposes:This PR separates those two responsibilities. [A] remains in
Microsoft.AspNetCore.Components.Browser, whereas [B] moves toMicrosoft.AspNetCore.Blazor. This helps a lot to clarify the distinction between "Razor Components" and "Blazor".The main thing forcing this change is that we need to include
.Components.Browserinside the shared framework, but we do not (at this stage) want the shared framework to include any dependency on Mono.* packages. With this PR, it's only.Blazorthat needs to referenceMono.WebAssembly.Interop, so all is well.I expect to make some further renames to the classes that have moved. Things like
BrowserServiceProvidershould really be calledWebAssemblyServiceProvider. But with PRs like this that move a lot of files around, it's safer to merge sooner rather than later to avoid difficult rebases later.