Skip to content

Skip some Razor build tests to observe effect on test runner #56292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

SteveSandersonMS
Copy link
Member

@SteveSandersonMS SteveSandersonMS commented Jun 18, 2024

On several builds, the test RazorPages_AreUpdatedOnChange has been the very last one before The active test run was aborted. Reason: Test host process crashed.

Checking to see whether skipping that test (and a similar one) results in a different outcome.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 18, 2024
@SteveSandersonMS SteveSandersonMS marked this pull request as ready for review June 20, 2024 08:46
@SteveSandersonMS SteveSandersonMS requested a review from a team as a code owner June 20, 2024 08:46
@SteveSandersonMS SteveSandersonMS requested a review from a team June 20, 2024 08:47
@SteveSandersonMS
Copy link
Member Author

SteveSandersonMS commented Jun 20, 2024

Reviewers: I can't 100% promise this is the true fix to the Helix reliability issues, but it has passed the Helix run every time I've run it with these tests skipped [1], so it seems reasonable to give this a go.

[1] Either actually passed, or in one case failed but it was an actual specific test failure not the generic "test host process crashed" that we've been getting for months

@SteveSandersonMS SteveSandersonMS merged commit cd92ed1 into main Jun 20, 2024
26 checks passed
@SteveSandersonMS SteveSandersonMS deleted the stevesa/skip-razor-build-test branch June 20, 2024 09:12
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview6 milestone Jun 20, 2024
SteveSandersonMS added a commit that referenced this pull request Jun 20, 2024
…56292)"

It didn't actually do anything because it's also necessary to use [ConditionalFact],

This reverts commit cd92ed1.
@los93sol
Copy link

I this the reason .NET 9 projects load up Chrome in just an empty tab with "about:blank"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants