Skip Templates.Mvc.Tests in Helix on Debian12 and Mariner #56291
Conversation
dotnet-issue-labeler
bot
added
the
area-mvc
| <!-- These tests fail in Helix in Debian and Mariner due to error -901 --> | ||
| <!-- Disabling on those OSes until a better fix can be identified --> | ||
| <SkipHelixQueues> | ||
| $(HelixQueueDebian12); | ||
| $(HelixQueueMariner); | ||
| $(SkipHelixQueues) | ||
| </SkipHelixQueues> |
There was a problem hiding this comment.
Do we need to skip the whole assembly? Or can we just skip the individual failing tests?
There was a problem hiding this comment.
Nope, this was just an experiment. Thanks for pointing it out though.
Since then I made another PR with a more narrow skip condition which has now been merged: #56292
There was a problem hiding this comment.
Update: no, the above comment is incorrect.
Yes we do need to skip the whole assembly since there isn't an individual failing test. It's an unknown timeout problem.
There was a problem hiding this comment.
Do we need to skip the whole assembly? Or can we just skip the individual failing tests?
TBH, I think we should probably skip the entire test assembly. I know that is a bit heavy handed but, from looking at a few of the recent test process crashes, there's no correlation between particular tests and expected failures. It's all over the board.
|
Superseded by #56292 Update: actually no that's not true, I remembered now (with thanks to @BrennanConroy) the two PRs are addessing unrelated problems. |
There was a problem hiding this comment.
LGTM! I think we should skip these tests and focus our diagnosis efforts on getting local repros working for this failure.
For whatever reason, these test builds aren't producing dump files correctly so outside of the logs were not getting any additional signal from the failures.
Edit: Actually, I wonder if there is a way for us to quarantine an entire test assembly...
SteveSandersonMS
deleted the
stevesa/disable-mvc-template-tests-on-some-helix-oses
branch
|
Filed #56450 to track undoing this. |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/10080675797 |
|
@mkArtakMSFT backporting to release/8.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Skip Templates.Mvc.Tests in Helix on Debian12 and Mariner
Using index info to reconstruct a base tree...
M src/ProjectTemplates/test/Templates.Mvc.Tests/Templates.Mvc.Tests.csproj
Falling back to patching base and 3-way merge...
Auto-merging src/ProjectTemplates/test/Templates.Mvc.Tests/Templates.Mvc.Tests.csproj
CONFLICT (content): Merge conflict in src/ProjectTemplates/test/Templates.Mvc.Tests/Templates.Mvc.Tests.csproj
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Skip Templates.Mvc.Tests in Helix on Debian12 and Mariner
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@mkArtakMSFT an error occurred while backporting to release/8.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
This one was missed in #56291 and no-one updated it since :/
These tests have been failing on Debian and Mariner for months. This has continued through many build ops rotations without progress.
To bring the build closer to a stable state, skipping them on those OSes until a better fix can be identified.