Skip to content

Skip Templates.Mvc.Tests in Helix on Debian12 and Mariner #56291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Skip Templates.Mvc.Tests in Helix on Debian12 and Mariner #56291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/ProjectTemplates/test/Templates.Mvc.Tests/Templates.Mvc.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@
<RestoreFolderName>Mvc</RestoreFolderName>
<TestDependsOnAspNetPackages>true</TestDependsOnAspNetPackages>
<HelixTimeout>02:30:00</HelixTimeout>

<!-- These tests fail in Helix in Debian and Mariner due to error -901 -->
<!-- Disabling on those OSes until a better fix can be identified -->
<SkipHelixQueues>
$(HelixQueueDebian12);
$(HelixQueueMariner);
$(SkipHelixQueues)
</SkipHelixQueues>
Comment on lines +24 to +30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to skip the whole assembly? Or can we just skip the individual failing tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this was just an experiment. Thanks for pointing it out though.

Since then I made another PR with a more narrow skip condition which has now been merged: #56292

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: no, the above comment is incorrect.

Yes we do need to skip the whole assembly since there isn't an individual failing test. It's an unknown timeout problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to skip the whole assembly? Or can we just skip the individual failing tests?

TBH, I think we should probably skip the entire test assembly. I know that is a bit heavy handed but, from looking at a few of the recent test process crashes, there's no correlation between particular tests and expected failures. It's all over the board.

</PropertyGroup>

<ItemGroup>
Expand Down
Loading